chrome/browser/extensions/extension_info_map.h - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_info_map.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementations Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/dns/dns_api.cc ('K') | « chrome/browser/extensions/extension_idle_api.cc ('k') | chrome/browser/extensions/extension_info_map.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_info_map.h

diff --git a/chrome/browser/extensions/extension_info_map.h b/chrome/browser/extensions/extension_info_map.h

index 8b00664291381025d0fd4b993708ccf885ec1f1c..df8a6c5fe2e474184677b42d2013636afae4841b 100644

--- a/chrome/browser/extensions/extension_info_map.h

+++ b/chrome/browser/extensions/extension_info_map.h

@@ -25,7 +25,6 @@ class Extension;

class ExtensionInfoMap : public base::RefCountedThreadSafe<ExtensionInfoMap> {

public:

ExtensionInfoMap();

- ~ExtensionInfoMap();

const ExtensionSet& extensions() const { return extensions_; }

const ExtensionSet& disabled_extensions() const {

@@ -74,11 +73,15 @@ class ExtensionInfoMap : public base::RefCountedThreadSafe<ExtensionInfoMap> {

ExtensionsQuotaService* GetQuotaService();

private:

+ friend class base::RefCountedThreadSafe<ExtensionInfoMap>;

// Extra dynamic data related to an extension.

struct ExtraData;

// Map of extension_id to ExtraData.

typedef std::map<std::string, ExtraData> ExtraDataMap;

+ ~ExtensionInfoMap();

ExtensionSet extensions_;

ExtensionSet disabled_extensions_;