chrome/browser/extensions/api/socket/tcp_socket_unittest.cc - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementations Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/dns/dns_api.cc ('K') | « chrome/browser/extensions/api/socket/socket_api.cc ('k') | chrome/browser/extensions/api/socket/udp_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

index 1573fa57e4756216a2d107ef244dd4d330352e1e..a6f55715fe92c98f6e6df251ef152b2e34fc53ad 100644

--- a/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/tcp_socket_unittest.cc

@@ -44,6 +44,9 @@ class MockAPIResourceEventNotifier : public APIResourceEventNotifier {

MOCK_METHOD2(OnReadComplete, void(int result_code,

const std::string& message));

MOCK_METHOD1(OnWriteComplete, void(int result_code));

+ protected:

+ virtual ~MockAPIResourceEventNotifier() {}

};

TEST(SocketTest, TestTCPSocketRead) {