Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: chrome/browser/extensions/api/bluetooth/bluetooth_api.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementations Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bluetooth/bluetooth_api.h
diff --git a/chrome/browser/extensions/api/bluetooth/bluetooth_api.h b/chrome/browser/extensions/api/bluetooth/bluetooth_api.h
index 86efb5f5d49a1f6ef15f493a47ea6204b81d929a..e8da7d27c2626bcdc7a6f3fb6ebd2f4e876f33a9 100644
--- a/chrome/browser/extensions/api/bluetooth/bluetooth_api.h
+++ b/chrome/browser/extensions/api/bluetooth/bluetooth_api.h
@@ -22,6 +22,8 @@ namespace api {
class BluetoothExtensionFunction : public SyncExtensionFunction {
protected:
+ virtual ~BluetoothExtensionFunction() {}
+
#if defined(OS_CHROMEOS)
const chromeos::BluetoothAdapter* adapter() const;
chromeos::BluetoothAdapter* GetMutableAdapter();
@@ -38,40 +40,66 @@ class AsyncBluetoothExtensionFunction : public AsyncExtensionFunction {
class BluetoothIsAvailableFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.isAvailable")
+
+ protected:
+ virtual ~BluetoothIsAvailableFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothIsPoweredFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.isPowered")
+
+ protected:
+ virtual ~BluetoothIsPoweredFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothGetAddressFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.getAddress")
+
+ protected:
+ virtual ~BluetoothGetAddressFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothGetDevicesWithServiceUUIDFunction
: public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.bluetooth.getDevicesWithServiceUUID")
+
+ protected:
+ virtual ~BluetoothGetDevicesWithServiceFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothGetDevicesWithServiceNameFunction
: public AsyncBluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.bluetooth.getDevicesWithServiceName")
+ protected:
#if defined(OS_CHROMEOS)
BluetoothGetDevicesWithServiceNameFunction();
+ virtual ~BluetoothGetDevicesWithServiceNameFunction();
+#endif
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
+#if defined(OS_CHROMEOS)
private:
void AddDeviceIfTrue(
ListValue* list, const chromeos::BluetoothDevice* device, bool result);
@@ -82,42 +110,72 @@ class BluetoothGetDevicesWithServiceNameFunction
class BluetoothDisconnectFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.disconnect")
+
+ protected:
+ virtual ~BluetoothDisconnectFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothReadFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.read")
+
+ protected:
+ virtual ~BluetoothReadFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothSetOutOfBandPairingDataFunction
: public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.bluetooth.setOutOfBandPairingData")
+
+ protected:
+ virtual ~BluetoothSetOutOfBandPairingDataFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothGetOutOfBandPairingDataFunction
: public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME(
"experimental.bluetooth.getOutOfBandPairingData")
+
+ protected:
+ virtual ~BluetoothGetOutOfBandPairingDataFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothWriteFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.write")
+
+ private:
+ virtual ~BluetoothWriteFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
class BluetoothConnectFunction : public BluetoothExtensionFunction {
public:
- virtual bool RunImpl() OVERRIDE;
DECLARE_EXTENSION_FUNCTION_NAME("experimental.bluetooth.connect")
+
+ protected:
+ virtual ~BluetoothConnectFunction() {}
+
+ // ExtensionFunction:
+ virtual bool RunImpl() OVERRIDE;
};
} // namespace api

Powered by Google App Engine
This is Rietveld 408576698