chrome/browser/extensions/api/api_resource_event_notifier.h - Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/api_resource_event_notifier.h

Issue 10071035: RefCounted types should not have public destructors, chrome/browser/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementations Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/api_function.cc ('k') | chrome/browser/extensions/api/api_resource_event_notifier.cc » ('j') | chrome/browser/extensions/api/dns/dns_api.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/api_resource_event_notifier.h

diff --git a/chrome/browser/extensions/api/api_resource_event_notifier.h b/chrome/browser/extensions/api/api_resource_event_notifier.h

index eb16a0118ed695ea241956a86b1e4766d2438528..a1afa36e25868e88eab47d9037c44b2110a6f3e4 100644

--- a/chrome/browser/extensions/api/api_resource_event_notifier.h

+++ b/chrome/browser/extensions/api/api_resource_event_notifier.h

@@ -48,7 +48,6 @@ class APIResourceEventNotifier

Profile* profile,

const std::string& src_extension_id, int src_id,

const GURL& src_url);

- virtual ~APIResourceEventNotifier();

virtual void OnConnectComplete(int result_code);

@@ -61,6 +60,11 @@ class APIResourceEventNotifier

APIResourceEventType event_type);

private:

+ friend class base::RefCountedThreadSafe<APIResourceEventNotifier>;

+ friend class MockAPIResourceEventNotifier;

+ virtual ~APIResourceEventNotifier();

void DispatchEvent(DictionaryValue* event);

void DispatchEventOnUIThread(DictionaryValue* event);

DictionaryValue* CreateAPIResourceEvent(APIResourceEventType event_type);