RefCounted types should not have public destructors, chrome/browser/extensions

chrome/browser/extensions/api/api_resource_event_notifier.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/api_resource_event_notifier.h"
 
 #include "base/bind.h"
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/extension_event_router.h"
@@ skipping 24 matching lines @@
 APIResourceEventNotifier::APIResourceEventNotifier(
     ExtensionEventRouter* router,
     Profile* profile,
     const std::string& src_extension_id,
     int src_id,
     const GURL& src_url)
     : router_(router),
       profile_(profile),
       src_extension_id_(src_extension_id),
       src_id_(src_id),
-      src_url_(src_url) {}
-
-APIResourceEventNotifier::~APIResourceEventNotifier() {}
+      src_url_(src_url) {
+}
 
 void APIResourceEventNotifier::OnConnectComplete(int result_code) {
   SendEventWithResultCode(API_RESOURCE_EVENT_CONNECT_COMPLETE, result_code);
 }
 
 void APIResourceEventNotifier::OnDataRead(int result_code,
                                           base::ListValue* data) {
   // Do we have a destination for this event? There will be one if a source id
   // was injected by the request handler for the resource's create method in
   // schema_generated_bindings.js, which will in turn be the case if the caller
   // of the create method provided an onEvent closure.
   if (src_id_ < 0) {
     delete data;
     return;
   }
 
   DictionaryValue* event = CreateAPIResourceEvent(
       API_RESOURCE_EVENT_DATA_READ);
   event->SetInteger(kResultCodeKey, result_code);
   event->Set(kDataKey, data);
   DispatchEvent(event);
 }
 
 void APIResourceEventNotifier::OnWriteComplete(int result_code) {
   SendEventWithResultCode(API_RESOURCE_EVENT_WRITE_COMPLETE, result_code);
 }
 
-void APIResourceEventNotifier::SendEventWithResultCode(
-    APIResourceEventType event_type,
-    int result_code) {
-  if (src_id_ < 0)
-    return;
+// static
+std::string APIResourceEventNotifier::APIResourceEventTypeToString(
+    APIResourceEventType event_type) {
+  switch (event_type) {
+    case API_RESOURCE_EVENT_CONNECT_COMPLETE:
+      return kEventTypeConnectComplete;
+    case API_RESOURCE_EVENT_DATA_READ:
+      return kEventTypeDataRead;
+    case API_RESOURCE_EVENT_WRITE_COMPLETE:
+      return kEventTypeWriteComplete;
+  }
 
-  DictionaryValue* event = CreateAPIResourceEvent(event_type);
-  event->SetInteger(kResultCodeKey, result_code);
-  DispatchEvent(event);
+  NOTREACHED();
+  return std::string();
 }
 
+APIResourceEventNotifier::~APIResourceEventNotifier() {}
+
 void APIResourceEventNotifier::DispatchEvent(DictionaryValue* event) {
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(
           &APIResourceEventNotifier::DispatchEventOnUIThread, this, event));
 }
 
 void APIResourceEventNotifier::DispatchEventOnUIThread(
     DictionaryValue* event) {
   ListValue args;
@@ skipping 16 matching lines @@
 
   // TODO(miket): Signal that it's OK to clean up onEvent listeners. This is
   // the framework we'll use, but we need to start using it.
   event->SetBoolean(kIsFinalEventKey, false);
 
   // The caller owns the created event, which typically is then given to a
   // ListValue to dispose of.
   return event;
 }
 
-// static
-std::string APIResourceEventNotifier::APIResourceEventTypeToString(
-    APIResourceEventType event_type) {
-  switch (event_type) {
-    case API_RESOURCE_EVENT_CONNECT_COMPLETE:
-      return kEventTypeConnectComplete;
-    case API_RESOURCE_EVENT_DATA_READ:
-      return kEventTypeDataRead;
-    case API_RESOURCE_EVENT_WRITE_COMPLETE:
-      return kEventTypeWriteComplete;
-  }
+void APIResourceEventNotifier::SendEventWithResultCode(
+    APIResourceEventType event_type,
+    int result_code) {
+  if (src_id_ < 0)
+    return;
 
-  NOTREACHED();
-  return std::string();
+  DictionaryValue* event = CreateAPIResourceEvent(event_type);
+  event->SetInteger(kResultCodeKey, result_code);
+  DispatchEvent(event);
 }
 
 }  // namespace extensions