Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: chrome/browser/sync/glue/history_model_worker.cc

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/history_model_worker.cc
diff --git a/chrome/browser/sync/glue/history_model_worker.cc b/chrome/browser/sync/glue/history_model_worker.cc
index 35d459d19c76306fd4bcb8d5dfc808582b57c060..9ad68f164f66eed125b59e9b79740bed885e885f 100644
--- a/chrome/browser/sync/glue/history_model_worker.cc
+++ b/chrome/browser/sync/glue/history_model_worker.cc
@@ -33,6 +33,8 @@ class WorkerTask : public HistoryDBTask {
virtual void DoneRunOnMainThread() {}
protected:
+ virtual ~WorkerTask() {}
+
WorkCallback work_;
WaitableEvent* done_;
SyncerError* error_;
@@ -44,9 +46,6 @@ HistoryModelWorker::HistoryModelWorker(HistoryService* history_service)
CHECK(history_service);
}
-HistoryModelWorker::~HistoryModelWorker() {
-}
-
SyncerError HistoryModelWorker::DoWorkAndWaitUntilDone(
const WorkCallback& work) {
WaitableEvent done(false, false);
@@ -61,4 +60,6 @@ ModelSafeGroup HistoryModelWorker::GetModelSafeGroup() {
return GROUP_HISTORY;
}
+HistoryModelWorker::~HistoryModelWorker() {}
+
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/glue/history_model_worker.h ('k') | chrome/browser/sync/glue/new_non_frontend_data_type_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698