Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: chrome/browser/sync/glue/browser_thread_model_worker.h

Issue 10071033: RefCounted types should not have public destructors, chrome/browser/ part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering fixes as well Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/browser_thread_model_worker.h
diff --git a/chrome/browser/sync/glue/browser_thread_model_worker.h b/chrome/browser/sync/glue/browser_thread_model_worker.h
index 53ca156cb6c632680e246603cae831399d60688d..97373a56f3c1d6830f26635b4f62df9baad291f2 100644
--- a/chrome/browser/sync/glue/browser_thread_model_worker.h
+++ b/chrome/browser/sync/glue/browser_thread_model_worker.h
@@ -26,7 +26,6 @@ class BrowserThreadModelWorker : public ModelSafeWorker {
public:
BrowserThreadModelWorker(content::BrowserThread::ID thread,
ModelSafeGroup group);
- virtual ~BrowserThreadModelWorker();
// ModelSafeWorker implementation. Called on the sync thread.
virtual SyncerError DoWorkAndWaitUntilDone(
@@ -34,6 +33,8 @@ class BrowserThreadModelWorker : public ModelSafeWorker {
virtual ModelSafeGroup GetModelSafeGroup() OVERRIDE;
protected:
+ virtual ~BrowserThreadModelWorker();
+
// Marked pure virtual so subclasses have to override, but there is
// an implementation that subclasses should use. This is so that
// (subclass)::CallDoWorkAndSignalTask shows up in callstacks.
@@ -55,25 +56,29 @@ class BrowserThreadModelWorker : public ModelSafeWorker {
class DatabaseModelWorker : public BrowserThreadModelWorker {
public:
DatabaseModelWorker();
- virtual ~DatabaseModelWorker();
protected:
virtual void CallDoWorkAndSignalTask(
const WorkCallback& work,
base::WaitableEvent* done,
SyncerError* error) OVERRIDE;
+
+ private:
+ virtual ~DatabaseModelWorker();
};
class FileModelWorker : public BrowserThreadModelWorker {
public:
FileModelWorker();
- virtual ~FileModelWorker();
protected:
virtual void CallDoWorkAndSignalTask(
const WorkCallback& work,
base::WaitableEvent* done,
SyncerError* error) OVERRIDE;
+
+ private:
+ virtual ~FileModelWorker();
};
} // namespace browser_sync

Powered by Google App Engine
This is Rietveld 408576698