chrome/browser/net/sqlite_server_bound_cert_store.h - Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/sqlite_server_bound_cert_store.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc ('k') | chrome/browser/net/sqlite_server_bound_cert_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/sqlite_server_bound_cert_store.h

diff --git a/chrome/browser/net/sqlite_server_bound_cert_store.h b/chrome/browser/net/sqlite_server_bound_cert_store.h

index da363a0b502e74c0e6ce50aecba44b37e2d800db..6647eeee3261637c4b412375cb1a4f3f424d50e7 100644

--- a/chrome/browser/net/sqlite_server_bound_cert_store.h

+++ b/chrome/browser/net/sqlite_server_bound_cert_store.h

@@ -21,9 +21,8 @@ class SQLiteServerBoundCertStore

: public net::DefaultServerBoundCertStore::PersistentStore {

public:

explicit SQLiteServerBoundCertStore(const FilePath& path);

- virtual ~SQLiteServerBoundCertStore();

- // net::DefaultServerBoundCertStore::PersistentStore implementation.

+ // net::DefaultServerBoundCertStore::PersistentStore:

virtual bool Load(

std::vector<net::DefaultServerBoundCertStore::ServerBoundCert*>* certs)

OVERRIDE;

@@ -34,6 +33,9 @@ class SQLiteServerBoundCertStore

virtual void SetClearLocalStateOnExit(bool clear_local_state) OVERRIDE;

virtual void Flush(const base::Closure& completion_task) OVERRIDE;

+ protected:

+ virtual ~SQLiteServerBoundCertStore();

private:

class Backend;