Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: chrome/browser/history/shortcuts_backend.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/in_memory_url_index.cc ('k') | chrome/browser/history/shortcuts_backend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/shortcuts_backend.h
diff --git a/chrome/browser/history/shortcuts_backend.h b/chrome/browser/history/shortcuts_backend.h
index 66892c7b2f8a458070cefa51da650aad80baec22..d36ff3732a75632ca3bbd4454ca7b2f522a0e559 100644
--- a/chrome/browser/history/shortcuts_backend.h
+++ b/chrome/browser/history/shortcuts_backend.h
@@ -73,7 +73,6 @@ class ShortcutsBackend : public base::RefCountedThreadSafe<ShortcutsBackend>,
// unit-tests. |db_folder_path| could be an empty path only in unit-tests as
// well. It means there is no database created, all things are done in memory.
ShortcutsBackend(const FilePath& db_folder_path, Profile* profile);
- virtual ~ShortcutsBackend();
// The interface is guaranteed to be called on the thread AddObserver()
// was called.
@@ -83,6 +82,7 @@ class ShortcutsBackend : public base::RefCountedThreadSafe<ShortcutsBackend>,
virtual void OnShortcutsLoaded() = 0;
// Called when shortcuts changed (added/updated/removed) in the database.
virtual void OnShortcutsChanged() {}
+
protected:
virtual ~ShortcutsBackendObserver() {}
};
@@ -123,9 +123,13 @@ class ShortcutsBackend : public base::RefCountedThreadSafe<ShortcutsBackend>,
}
private:
+ friend class base::RefCountedThreadSafe<ShortcutsBackend>;
+
typedef std::map<std::string, ShortcutMap::iterator>
GuidToShortcutsIteratorMap;
+ virtual ~ShortcutsBackend();
+
// Internal initialization of the back-end. Posted by Init() to the DB thread.
// On completion posts InitCompleted() back to UI thread.
void InitInternal();
« no previous file with comments | « chrome/browser/history/in_memory_url_index.cc ('k') | chrome/browser/history/shortcuts_backend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698