Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: chrome/browser/net/crl_set_fetcher.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/history/top_sites_unittest.cc ('k') | chrome/browser/net/crl_set_fetcher.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_NET_CRL_SET_FETCHER_H_ 5 #ifndef CHROME_BROWSER_NET_CRL_SET_FETCHER_H_
6 #define CHROME_BROWSER_NET_CRL_SET_FETCHER_H_ 6 #define CHROME_BROWSER_NET_CRL_SET_FETCHER_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 11 matching lines...) Expand all
22 namespace net { 22 namespace net {
23 class CRLSet; 23 class CRLSet;
24 } 24 }
25 25
26 class ComponentUpdateService; 26 class ComponentUpdateService;
27 27
28 class CRLSetFetcher : public ComponentInstaller, 28 class CRLSetFetcher : public ComponentInstaller,
29 public base::RefCountedThreadSafe<CRLSetFetcher> { 29 public base::RefCountedThreadSafe<CRLSetFetcher> {
30 public: 30 public:
31 CRLSetFetcher(); 31 CRLSetFetcher();
32 virtual ~CRLSetFetcher();
33 32
34 void StartInitialLoad(ComponentUpdateService* cus); 33 void StartInitialLoad(ComponentUpdateService* cus);
35 34
36 // ComponentInstaller interface 35 // ComponentInstaller interface
37 virtual void OnUpdateError(int error) OVERRIDE; 36 virtual void OnUpdateError(int error) OVERRIDE;
38 virtual bool Install(base::DictionaryValue* manifest, 37 virtual bool Install(base::DictionaryValue* manifest,
39 const FilePath& unpack_path) OVERRIDE; 38 const FilePath& unpack_path) OVERRIDE;
40 39
41 private: 40 private:
41 friend class base::RefCountedThreadSafe<CRLSetFetcher>;
42
43 virtual ~CRLSetFetcher();
44
42 // GetCRLSetFilePath gets the path of the CRL set file in the user data 45 // GetCRLSetFilePath gets the path of the CRL set file in the user data
43 // dir. 46 // dir.
44 bool GetCRLSetFilePath(FilePath* path) const; 47 bool GetCRLSetFilePath(FilePath* path) const;
45 48
46 // DoInitialLoadFromDisk runs on the FILE thread and attempts to load a CRL 49 // DoInitialLoadFromDisk runs on the FILE thread and attempts to load a CRL
47 // set from the user-data dir. It then registers this object as a component 50 // set from the user-data dir. It then registers this object as a component
48 // in order to get updates. 51 // in order to get updates.
49 void DoInitialLoadFromDisk(); 52 void DoInitialLoadFromDisk();
50 53
51 // LoadFromDisk runs on the FILE thread and attempts to load a CRL set 54 // LoadFromDisk runs on the FILE thread and attempts to load a CRL set
(...skipping 11 matching lines...) Expand all
63 ComponentUpdateService* cus_; 66 ComponentUpdateService* cus_;
64 67
65 // We keep a pointer to the current CRLSet for use on the FILE thread when 68 // We keep a pointer to the current CRLSet for use on the FILE thread when
66 // applying delta updates. 69 // applying delta updates.
67 scoped_refptr<net::CRLSet> crl_set_; 70 scoped_refptr<net::CRLSet> crl_set_;
68 71
69 DISALLOW_COPY_AND_ASSIGN(CRLSetFetcher); 72 DISALLOW_COPY_AND_ASSIGN(CRLSetFetcher);
70 }; 73 };
71 74
72 #endif // CHROME_BROWSER_NET_CRL_SET_FETCHER_H_ 75 #endif // CHROME_BROWSER_NET_CRL_SET_FETCHER_H_
OLDNEW
« no previous file with comments | « chrome/browser/history/top_sites_unittest.cc ('k') | chrome/browser/net/crl_set_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698