RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/shortcuts_database.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/shortcuts_database.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 40 matching lines @@
 
 namespace history {
 
 const FilePath::CharType ShortcutsDatabase::kShortcutsDatabaseName[] =
     FILE_PATH_LITERAL("Shortcuts");
 
 ShortcutsDatabase::ShortcutsDatabase(const FilePath& folder_path)
     : database_path_(folder_path.Append(FilePath(kShortcutsDatabaseName))) {
 }
 
-ShortcutsDatabase::~ShortcutsDatabase() {}
-
 bool ShortcutsDatabase::Init() {
   // Set the database page size to something a little larger to give us
   // better performance (we're typically seek rather than bandwidth limited).
   // This only has an effect before any tables have been created, otherwise
   // this is a NOP. Must be a power of 2 and a max of 8192.
   db_.set_page_size(4096);
 
   // Run the database in exclusive mode. Nobody else should be accessing the
   // database while we're running, and this will give somewhat improved perf.
   db_.set_exclusive_locking();
@@ skipping 78 matching lines @@
         ShortcutsBackend::Shortcut(s.ColumnString(0), s.ColumnString16(1),
             GURL(s.ColumnString(2)), s.ColumnString16(3),
             AutocompleteMatch::ClassificationsFromString(s.ColumnString(4)),
             s.ColumnString16(5),
             AutocompleteMatch::ClassificationsFromString(s.ColumnString(6)),
             base::Time::FromInternalValue(s.ColumnInt64(7)), s.ColumnInt(8))));
   }
   return true;
 }
 
+ShortcutsDatabase::~ShortcutsDatabase() {}
+
 bool ShortcutsDatabase::EnsureTable() {
   if (!db_.DoesTableExist(kShortcutsDBName)) {
     if (!db_.Execute(base::StringPrintf(
                      "CREATE TABLE %s ( "
                      "id VARCHAR PRIMARY KEY, "
                      "text VARCHAR, "
                      "url VARCHAR, "
                      "contents VARCHAR, "
                      "contents_class VARCHAR, "
                      "description VARCHAR, "
                      "description_class VARCHAR, "
                      "last_access_time INTEGER, "
                      "number_of_hits INTEGER)", kShortcutsDBName).c_str())) {
       NOTREACHED();
       return false;
     }
   }
   return true;
 }
 
 }  // namespace history