RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/shortcuts_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/history/shortcuts_backend.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 77 matching lines @@
       no_db_access_(db_folder_path.empty()) {
   // |profile| can be NULL in tests.
   if (profile) {
     notification_registrar_.Add(this, chrome::NOTIFICATION_OMNIBOX_OPENED_URL,
                                 content::Source<Profile>(profile));
     notification_registrar_.Add(this, chrome::NOTIFICATION_HISTORY_URLS_DELETED,
                                 content::Source<Profile>(profile));
   }
 }
 
-ShortcutsBackend::~ShortcutsBackend() {}
-
 bool ShortcutsBackend::Init() {
   if (current_state_ != NOT_INITIALIZED)
     return false;
 
   if (no_db_access_) {
     current_state_ = INITIALIZED;
     return true;
   }
 
   current_state_ = INITIALIZING;
@@ skipping 73 matching lines @@
     return false;
   shortcuts_map_.clear();
   guid_map_.clear();
   FOR_EACH_OBSERVER(ShortcutsBackendObserver, observer_list_,
                     OnShortcutsChanged());
   return no_db_access_ || BrowserThread::PostTask(BrowserThread::DB, FROM_HERE,
       base::Bind(base::IgnoreResult(&ShortcutsDatabase::DeleteAllShortcuts),
                  db_.get()));
 }
 
+ShortcutsBackend::~ShortcutsBackend() {}
+
 void ShortcutsBackend::InitInternal() {
   DCHECK(current_state_ == INITIALIZING);
   db_->Init();
   ShortcutsDatabase::GuidToShortcutMap shortcuts;
   db_->LoadShortcuts(&shortcuts);
   temp_shortcuts_map_.reset(new ShortcutMap);
   temp_guid_map_.reset(new GuidToShortcutsIteratorMap);
   for (ShortcutsDatabase::GuidToShortcutMap::iterator it = shortcuts.begin();
        it != shortcuts.end(); ++it) {
     (*temp_guid_map_)[it->first] = temp_shortcuts_map_->insert(
@@ skipping 55 matching lines @@
           it->second.number_of_hits + 1));
       return;
     }
   }
   AddShortcut(Shortcut(guid::GenerateGUID(), log->text, match.destination_url,
       match.contents, match.contents_class, match.description,
       match.description_class, base::Time::Now(), 1));
 }
 
 }  // namespace history