Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/component_updater/component_updater_service.cc

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/history/history_browsertest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/component_updater/component_updater_service.h" 5 #include "chrome/browser/component_updater/component_updater_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/at_exit.h" 10 #include "base/at_exit.h"
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
253 IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseUpdateManifest_Succeeded, 253 IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseUpdateManifest_Succeeded,
254 OnParseUpdateManifestSucceeded) 254 OnParseUpdateManifestSucceeded)
255 IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseUpdateManifest_Failed, 255 IPC_MESSAGE_HANDLER(ChromeUtilityHostMsg_ParseUpdateManifest_Failed,
256 OnParseUpdateManifestFailed) 256 OnParseUpdateManifestFailed)
257 IPC_MESSAGE_UNHANDLED(handled = false) 257 IPC_MESSAGE_UNHANDLED(handled = false)
258 IPC_END_MESSAGE_MAP() 258 IPC_END_MESSAGE_MAP()
259 return handled; 259 return handled;
260 } 260 }
261 261
262 private: 262 private:
263 virtual ~ManifestParserBridge() {}
264
263 // Omaha update response XML was successfully parsed. 265 // Omaha update response XML was successfully parsed.
264 void OnParseUpdateManifestSucceeded(const UpdateManifest::Results& r) { 266 void OnParseUpdateManifestSucceeded(const UpdateManifest::Results& r) {
265 service_->OnParseUpdateManifestSucceeded(r); 267 service_->OnParseUpdateManifestSucceeded(r);
266 } 268 }
267 // Omaha update response XML could not be parsed. 269 // Omaha update response XML could not be parsed.
268 void OnParseUpdateManifestFailed(const std::string& e) { 270 void OnParseUpdateManifestFailed(const std::string& e) {
269 service_->OnParseUpdateManifestFailed(e); 271 service_->OnParseUpdateManifestFailed(e);
270 } 272 }
271 273
272 CrxUpdateService* service_; 274 CrxUpdateService* service_;
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 ScheduleNextRun(false); 768 ScheduleNextRun(false);
767 } 769 }
768 770
769 // The component update factory. Using the component updater as a singleton 771 // The component update factory. Using the component updater as a singleton
770 // is the job of the browser process. 772 // is the job of the browser process.
771 ComponentUpdateService* ComponentUpdateServiceFactory( 773 ComponentUpdateService* ComponentUpdateServiceFactory(
772 ComponentUpdateService::Configurator* config) { 774 ComponentUpdateService::Configurator* config) {
773 DCHECK(config); 775 DCHECK(config);
774 return new CrxUpdateService(config); 776 return new CrxUpdateService(config);
775 } 777 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/history/history_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698