chrome/browser/history/top_sites_extension_api.h - Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/history/top_sites_extension_api.h

Issue 10071032: RefCounted types should not have public destructors, chrome/browser/ part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/history/shortcuts_database.h ('K') | « chrome/browser/history/top_sites.cc ('k') | chrome/browser/history/top_sites_unittest.cc » ('j') | chrome/browser/net/sqlite_persistent_cookie_store.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_EXTENSION_API_H_	5 #ifndef CHROME_BROWSER_HISTORY_TOP_SITES_EXTENSION_API_H_

6 #define CHROME_BROWSER_HISTORY_TOP_SITES_EXTENSION_API_H_	6 #define CHROME_BROWSER_HISTORY_TOP_SITES_EXTENSION_API_H_

7 #pragma once	7 #pragma once

8	8

9 #include "chrome/browser/cancelable_request.h"	9 #include "chrome/browser/cancelable_request.h"

10 #include "chrome/browser/extensions/extension_function.h"	10 #include "chrome/browser/extensions/extension_function.h"

11 #include "chrome/browser/history/history_types.h"	11 #include "chrome/browser/history/history_types.h"

12	12

13 class GetTopSitesFunction : public AsyncExtensionFunction {	13 class GetTopSitesFunction : public AsyncExtensionFunction {

14 public:	14 public:

15 GetTopSitesFunction();	15 GetTopSitesFunction();

16 virtual ~GetTopSitesFunction();	16

	17 protected:

17 virtual bool RunImpl() OVERRIDE;	18 virtual bool RunImpl() OVERRIDE;

18 DECLARE_EXTENSION_FUNCTION_NAME("topSites.get")	19 DECLARE_EXTENSION_FUNCTION_NAME("topSites.get")

19	20

20 private:	21 private:

	22 virtual ~GetTopSitesFunction();

	23

21 void OnMostVisitedURLsAvailable(	24 void OnMostVisitedURLsAvailable(

22 const history::MostVisitedURLList& data);	25 const history::MostVisitedURLList& data);

23	26

24 CancelableRequestConsumer topsites_consumer_;	27 CancelableRequestConsumer topsites_consumer_;

25 };	28 };

26	29

27 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_EXTENSION_API_H_	30 #endif // CHROME_BROWSER_HISTORY_TOP_SITES_EXTENSION_API_H_

OLD	NEW