RefCounted types should not have public destructors, chrome/browser/ part 1

chrome/browser/history/shortcuts_backend.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_HISTORY_SHORTCUTS_BACKEND_H_
 #define CHROME_BROWSER_HISTORY_SHORTCUTS_BACKEND_H_
 #pragma once
 
 #include <map>
 #include <string>
@@ skipping 55 matching lines @@
     base::Time last_access_time;  // Last time shortcut was selected.
     int number_of_hits;           // How many times shortcut was selected.
   };
 
   typedef std::multimap<string16, ShortcutsBackend::Shortcut> ShortcutMap;
 
   // |profile| is necessary for profile notifications only and can be NULL in
   // unit-tests. |db_folder_path| could be an empty path only in unit-tests as
   // well. It means there is no database created, all things are done in memory.
   ShortcutsBackend(const FilePath& db_folder_path, Profile* profile);
-  virtual ~ShortcutsBackend();
 
   // The interface is guaranteed to be called on the thread AddObserver()
   // was called.
   class ShortcutsBackendObserver {
    public:
     // Called after the database is loaded and Init() completed.
     virtual void OnShortcutsLoaded() = 0;
     // Called when shortcuts changed (added/updated/removed) in the database.
     virtual void OnShortcutsChanged() {}
+
    protected:
     virtual ~ShortcutsBackendObserver() {}
   };
 
   // Asynchronously initializes the ShortcutsBackend, it is safe to call
   // multiple times - only the first call will be processed.
   bool Init();
 
   bool initialized() const { return current_state_ == INITIALIZED; }
 
@@ skipping 20 matching lines @@
 
   void AddObserver(ShortcutsBackendObserver* obs) {
     observer_list_.AddObserver(obs);
   }
 
   void RemoveObserver(ShortcutsBackendObserver* obs) {
     observer_list_.RemoveObserver(obs);
   }
 
  private:
+  friend class base::RefCountedThreadSafe<ShortcutsBackend>;
+
   typedef std::map<std::string, ShortcutMap::iterator>
       GuidToShortcutsIteratorMap;
 
+  virtual ~ShortcutsBackend();

[sky, 2012/04/13 15:50:52]

Move implementation to match new position.

+
   // Internal initialization of the back-end. Posted by Init() to the DB thread.
   // On completion posts InitCompleted() back to UI thread.
   void InitInternal();
 
   // Finishes initialization on UI thread, notifies all observers.
   void InitCompleted();
 
   // content::NotificationObserver:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
@@ skipping 23 matching lines @@
 
   // For some unit-test only.
   bool no_db_access_;
 
   DISALLOW_COPY_AND_ASSIGN(ShortcutsBackend);
 };
 
 }  // namespace history
 
 #endif  // CHROME_BROWSER_HISTORY_SHORTCUTS_BACKEND_H_