Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3644)

Unified Diff: remoting/remoting.gyp

Issue 10071027: [Chromoting] Add target to build archive for remoting_me2me_host files. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/remoting.gyp
===================================================================
--- remoting/remoting.gyp (revision 132078)
+++ remoting/remoting.gyp (working copy)
@@ -166,6 +166,18 @@
'resources/infographic_remote_assistance.png',
'resources/tick.png',
],
+ 'remoting_host_installer_mac_root': 'host/installer/mac/',
+ 'remoting_host_installer_mac_files': [
+ 'host/installer/mac/ChromeRemoteDesktop.packproj',
+ 'host/installer/mac/Chromoting.packproj',
+ 'host/installer/mac/LaunchAgents/org.chromium.chromoting.plist',
+ 'host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.json',
+ 'host/installer/mac/PrivilegedHelperTools/org.chromium.chromoting.me2me.sh',
+ 'host/installer/mac/Scripts/keystone_install.sh',
+ 'host/installer/mac/Scripts/remoting_postflight.sh',
+ 'host/installer/mac/Scripts/uninstall.sh',
+ 'host/installer/mac/Keystone/*',
+ ],
},
'target_defaults': {
@@ -1076,7 +1088,78 @@
],
}, # end of target 'remoting_host_keygen'
+ # This packages up the files needed for the remoting host installer so
+ # they can be sent off to be signed.
+ # We don't build an installer here because we don't have signed binaries.
{
+ 'target_name': 'remoting_me2me_host_archive',
+ 'type': 'none',
+ 'dependencies': [
+ 'remoting_me2me_host',
+ ],
+ 'sources': [
+ 'host/installer/build-installer-archive.py',
+ ],
+ 'conditions': [
+ ['OS=="mac"', {
+ 'sources': [
+ '<@(remoting_host_installer_mac_files)',
+ ],
+ }], # OS=="mac"
+ ['OS=="win"', {
+ 'dependencies': [
+ # TODO(garykac)
+ ],
+ }], # OS=="win"
+ ], # conditions
+ 'actions': [
+ {
+ 'action_name': 'Zip installer files for signing',
+ 'temp_dir': '<(SHARED_INTERMEDIATE_DIR)/remoting/remoting-me2me-host',
+ 'zip_path': '<(PRODUCT_DIR)/remoting-me2me-host-<(OS).zip',
+ 'binaries_src': [],
+ 'binaries_dst': [],
+ 'other_files_root': '',
alexeypa (please no reviews) 2012/04/13 17:27:13 Naming is confusing. How about: binaries_src -> g
garykac 2012/04/13 18:06:03 Done.
+ 'other_files': [],
+ 'conditions': [
+ ['OS=="mac"', {
+ 'binaries_src': [
+ '<(PRODUCT_DIR)/remoting_me2me_host',
+ ],
+ 'binaries_dst': [
+ 'PrivilegedHelperTools/org.chromium.chromoting.me2me_host',
+ ],
+ 'other_files_root': '<(remoting_host_installer_mac_root)',
+ 'other_files': [
+ '<@(remoting_host_installer_mac_files)',
+ ],
+ }], # OS=="mac"
+ ], # conditions
+ 'inputs': [
+ 'host/installer/build-installer-archive.py',
alexeypa (please no reviews) 2012/04/13 17:27:13 Are you sure that the script should be listed here
garykac 2012/04/13 18:06:03 The script name is an input to python.
+ '<@(_other_files)',
+ ],
+ 'outputs': [
+ '<(_zip_path)',
+ ],
+ 'action': [
+ 'python',
+ 'host/installer/build-installer-archive.py',
+ '<(_temp_dir)',
+ '<(_zip_path)',
+ '<(_other_files_root)',
+ '--files',
+ '<@(_other_files)',
+ '--binaries-src',
+ '<@(_binaries_src)',
+ '--binaries-dst',
+ '<@(_binaries_dst)',
+ ],
+ },
+ ], # actions
+ }, # end of target 'remoting_me2me_host_archive'
+
+ {
'target_name': 'remoting_jingle_glue',
'type': 'static_library',
'variables': { 'enable_wexit_time_destructors': 1, },

Powered by Google App Engine
This is Rietveld 408576698