[Chromoting] Add target to build archive for remoting_me2me_host files.

[Chromoting] Add target to build archive for remoting_me2me_host files.

This archive contains all the files that need to be signed or are
required to build the Me2Me host installer.

Currently only setup for Mac. Other platforms either don't need this (Linux)
or are much simpler (Windows).

BUG=122228
Test=None
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132270

[alexeypa (please no reviews), 2012-04-13 17:27:12]

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
File remoting/host/installer/build-installer-archive.py (right):

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:6: """Create a zip archive
for the Chrome Remote Desktop Host installer.
nit: Create -> Creates?

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:6: """Create a zip archive
for the Chrome Remote Desktop Host installer.
Add TODO about merging this script with the one that is used for creation of the
webapp.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:23: """Delete and recreate
the dir to make sure it is clean.
nit: Deletes and recreates

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:56: """Copy the src_file into
the out_dir, preserving the directory structure.
Copies :-)

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:76: """Build a zip archive
with the files needed to build the installer.
Builds

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:112: '--binaries-src <src
binary files...> '
nit: The way we map source files to their location in ZIP is confusing. Is there
an easy way to pass from GYP, say pairs of a file name and its location and name
in zip?

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:123: files_root = sys.argv[3]
What if there are less arguments than required?

http://codereview.chromium.org/10071027/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10071027/diff/1/remoting/remoting.gyp#newcode1122
remoting/remoting.gyp:1122: 'other_files_root': '',
Naming is confusing. How about:

binaries_src -> generated_files
binaries_dst -> generated_destinations
other_files -> source_files
other_files_root -> source_root

The names in the script should be changed similarly.

http://codereview.chromium.org/10071027/diff/1/remoting/remoting.gyp#newcode1139
remoting/remoting.gyp:1139: 'host/installer/build-installer-archive.py',
Are you sure that the script should be listed here? I thought it is only for the
input files.

[garykac, 2012-04-13 18:06:03]

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
File remoting/host/installer/build-installer-archive.py (right):

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:6: """Create a zip archive
for the Chrome Remote Desktop Host installer.
On 2012/04/13 17:27:13, alexeypa wrote:
> Add TODO about merging this script with the one that is used for creation of
the
> webapp.

Done.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:6: """Create a zip archive
for the Chrome Remote Desktop Host installer.
On 2012/04/13 17:27:13, alexeypa wrote:
> nit: Create -> Creates?

Done.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:23: """Delete and recreate
the dir to make sure it is clean.
On 2012/04/13 17:27:13, alexeypa wrote:
> nit: Deletes and recreates

Done.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:56: """Copy the src_file into
the out_dir, preserving the directory structure.
On 2012/04/13 17:27:13, alexeypa wrote:
> Copies :-)

Done.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:76: """Build a zip archive
with the files needed to build the installer.
On 2012/04/13 17:27:13, alexeypa wrote:
> Builds

Done.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:112: '--binaries-src <src
binary files...> '
On 2012/04/13 17:27:13, alexeypa wrote:
> nit: The way we map source files to their location in ZIP is confusing. Is
there
> an easy way to pass from GYP, say pairs of a file name and its location and
name
> in zip?

We need a flat array of filenames for gyp dependencies. We could add another
mapping array, but it would duplicate the info in the flat array.

http://codereview.chromium.org/10071027/diff/1/remoting/host/installer/build-...
remoting/host/installer/build-installer-archive.py:123: files_root = sys.argv[3]
On 2012/04/13 17:27:13, alexeypa wrote:
> What if there are less arguments than required?

Changed above check to ensure 3 or more args.

http://codereview.chromium.org/10071027/diff/1/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10071027/diff/1/remoting/remoting.gyp#newcode1122
remoting/remoting.gyp:1122: 'other_files_root': '',
On 2012/04/13 17:27:13, alexeypa wrote:
> Naming is confusing. How about:
> 
> binaries_src -> generated_files
> binaries_dst -> generated_destinations
> other_files -> source_files
> other_files_root -> source_root
> 
> The names in the script should be changed similarly.

Done.

http://codereview.chromium.org/10071027/diff/1/remoting/remoting.gyp#newcode1139
remoting/remoting.gyp:1139: 'host/installer/build-installer-archive.py',
On 2012/04/13 17:27:13, alexeypa wrote:
> Are you sure that the script should be listed here? I thought it is only for
the
> input files.

The script name is an input to python.

[alexeypa (please no reviews), 2012-04-13 18:13:29]

LGTM

http://codereview.chromium.org/10071027/diff/4002/remoting/host/installer/bui...
File remoting/host/installer/build-installer-archive.py (right):

http://codereview.chromium.org/10071027/diff/4002/remoting/host/installer/bui...
remoting/host/installer/build-installer-archive.py:119: if len(sys.argv) < 3:
nit: Will it generate an empty .zip if only the first 3 arguments were passed?

[garykac, 2012-04-13 18:22:34]

http://codereview.chromium.org/10071027/diff/4002/remoting/host/installer/bui...
File remoting/host/installer/build-installer-archive.py (right):

http://codereview.chromium.org/10071027/diff/4002/remoting/host/installer/bui...
remoting/host/installer/build-installer-archive.py:119: if len(sys.argv) < 3:
On 2012/04/13 18:13:29, alexeypa wrote:
> nit: Will it generate an empty .zip if only the first 3 arguments were passed?

I added a check to return an error in that case.

[commit-bot: I haz the power, 2012-04-13 18:22:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/10071027/11002

[commit-bot: I haz the power, 2012-04-13 18:22:55]

Can't process patch for file remoting/host/installer/build-installer-archive.py.
Unsupported svn property format.