Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: remoting/host/elevated_controller_module_win.cc

Issue 10071025: [Chromoting] Make the Windows host controller ask the user to confirm host registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/elevated_controller_module_win.cc
diff --git a/remoting/host/elevated_controller_module_win.cc b/remoting/host/elevated_controller_module_win.cc
index 9d6442b14b0634534411efcca97d5b407e7cf3aa..38bbc634555538962f1f910dec03387ceb896a52 100644
--- a/remoting/host/elevated_controller_module_win.cc
+++ b/remoting/host/elevated_controller_module_win.cc
@@ -28,9 +28,13 @@ class ElevatedControllerModuleWin
remoting::ElevatedControllerModuleWin _AtlModule;
-int WINAPI WinMain(HINSTANCE, HINSTANCE, LPSTR, int command) {
+HINSTANCE g_hInstance = NULL;
alexeypa (please no reviews) 2012/04/12 21:20:41 nit: g_hInstance -> g_instance
alexeypa (please no reviews) 2012/04/12 21:20:41 I believe you should be able to use _AtlModule.Get
simonmorris 2012/04/12 22:11:44 Done.
simonmorris 2012/04/12 22:11:44 This way is consistent with host_plugin.cc. Is the
alexeypa (please no reviews) 2012/04/12 23:10:33 This way you don't pollute the global namespace an
simonmorris 2012/04/13 00:11:50 Done.
+
+int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE, LPSTR, int command) {
alexeypa (please no reviews) 2012/04/12 21:20:41 nit: hInstance -> instance
simonmorris 2012/04/12 22:11:44 Done.
CommandLine::Init(0, NULL);
+ g_hInstance = hInstance;
+
// This object instance is required by Chrome code (for example,
// FilePath, LazyInstance, MessageLoop).
base::AtExitManager exit_manager;

Powered by Google App Engine
This is Rietveld 408576698