remoting/host/elevated_controller.rc - Issue 10071025: [Chromoting] Make the Windows host controller ask the user to confirm host registration.

Side by Side Diff: remoting/host/elevated_controller.rc

Issue 10071025: [Chromoting] Make the Windows host controller ask the user to confirm host registration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 #include "afxres.h"	1 #include "afxres.h"

2	2

3 // Embedded type library.	3 // Embedded type library.

4 1 typelib "remoting/host/elevated_controller.tlb"	4 1 typelib "remoting/host/elevated_controller.tlb"

5	5

6 // English (U.S.) resources	6 // English (U.S.) resources

7 #if !defined(AFX_RESOURCE_DLL) \|\| defined(AFX_TARG_ENU)	7 #if !defined(AFX_RESOURCE_DLL) \|\| defined(AFX_TARG_ENU)

8 #ifdef _WIN32	8 #ifdef _WIN32

9 LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US	9 LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US

10 #pragma code_page(1252)	10 #pragma code_page(1252)

11 #endif //_WIN32	11 #endif //_WIN32

12	12

13 STRINGTABLE	13 STRINGTABLE

14 BEGIN	14 BEGIN

15 #ifdef OFFICIAL_BUILD	15 #ifdef OFFICIAL_BUILD

16 100 "Chrome Remote Desktop Host Controller"	16 100 "Chrome Remote Desktop Host Controller"
	alexeypa (please no reviews) 2012/04/12 21:20:41 Since you have introduced elevated_controller_reso Since you have introduced elevated_controller_resource.h you can define an IDS_XXX constant for this "100" simonmorris 2012/04/12 22:11:44 Done. Show quoted text On 2012/04/12 21:20:41, alexeypa wrote: > Since you have introduced elevated_controller_resource.h you can define an > IDS_XXX constant for this "100" Done.
17 #else	17 #else

18 100 "Chromoting Host Controller"	18 100 "Chromoting Host Controller"

19 #endif	19 #endif

20 END	20 END

21	21

22 #endif // English (U.S.) resources	22 #include "elevated_controller_resource.h"

	23

	24 /////////////////////////////////////////////////////////////////////////////

	25 //

	26 // Dialog

	27 //

	28

	29 IDD_VERIFY_CONFIG_DIALOG DIALOGEX 0, 0, 221, 120

	30 STYLE DS_SETFONT \| DS_MODALFRAME \| DS_FIXEDSYS \| WS_POPUP \| WS_CAPTION

	31 EXSTYLE WS_EX_TOPMOST
	alexeypa (please no reviews) 2012/04/12 21:20:41 This is usually a bad idea to make a modal dialog This is usually a bad idea to make a modal dialog a top-most window. Can we avoid that? simonmorris 2012/04/12 22:11:44 Without that style, the dialog may be hidden behin Show quoted text On 2012/04/12 21:20:41, alexeypa wrote: > This is usually a bad idea to make a modal dialog a top-most window. Can we > avoid that? Without that style, the dialog may be hidden behind the browser. Is there a way to open the dialog at the top of z-order, without making it be kept there? alexeypa (please no reviews) 2012/04/12 23:10:33 As per our discussion. It is up to the user to dec Show quoted text On 2012/04/12 22:11:44, simonmorris wrote: > On 2012/04/12 21:20:41, alexeypa wrote: > > This is usually a bad idea to make a modal dialog a top-most window. Can we > > avoid that? > > Without that style, the dialog may be hidden behind the browser. Is there a way > to open the dialog at the top of z-order, without making it be kept there? As per our discussion. It is up to the user to decide which window should be on top. Please add TODO that we need to pass HWND of the windows to be used as parent of the dialog. simonmorris 2012/04/13 00:11:50 Yes, but if the user doesn't realise that there is Show quoted text On 2012/04/12 23:10:33, alexeypa wrote: > On 2012/04/12 22:11:44, simonmorris wrote: > > On 2012/04/12 21:20:41, alexeypa wrote: > > > This is usually a bad idea to make a modal dialog a top-most window. Can we > > > avoid that? > > > > Without that style, the dialog may be hidden behind the browser. Is there a > way > > to open the dialog at the top of z-order, without making it be kept there? > > As per our discussion. It is up to the user to decide which window should be on > top. > Yes, but if the user doesn't realise that there is a new dialog window, that choice isn't very useful. Show quoted text > Please add TODO that we need to pass HWND of the windows to be used as parent of > the dialog. Done. alexeypa (please no reviews) 2012/04/13 17:34:29 The user doesn't need to realize that if he is wor Show quoted text On 2012/04/13 00:11:50, simonmorris wrote: > Yes, but if the user doesn't realise that there is a new dialog window, that > choice isn't very useful. The user doesn't need to realize that if he is working with a different window at the moment. The new dialog should have a button in the task bar that will be flashing to draw user's attention. simonmorris 2012/04/13 17:46:04 The button doesn't flash when I test. Show quoted text On 2012/04/13 17:34:29, alexeypa wrote: > On 2012/04/13 00:11:50, simonmorris wrote: > > Yes, but if the user doesn't realise that there is a new dialog window, that > > choice isn't very useful. > > The user doesn't need to realize that if he is working with a different window > at the moment. The new dialog should have a button in the task bar that will be > flashing to draw user's attention. The button doesn't flash when I test.
	32 CAPTION "kTitle"

	33 FONT 8, "MS Shell Dlg", 400, 0, 0x1

	34 BEGIN

	35 EDITTEXT IDC_PIN,7,69,107,15,WS_TABSTOP

	36 DEFPUSHBUTTON "kOK",IDOK,116,100,98,14,WS_TABSTOP

	37 LTEXT "kConfirmConfigChange",IDC_MESSAGE,7,7,207,30

	38 LTEXT "kEmail",IDC_EMAIL,7,38,207,30

	39 PUSHBUTTON "kCancel",IDCANCEL,7,100,98,14,WS_TABSTOP

	40 END

	41

	42

	43 /////////////////////////////////////////////////////////////////////////////

	44 //

	45 // DESIGNINFO

	46 //

	47

	48 #ifdef APSTUDIO_INVOKED

	49 GUIDELINES DESIGNINFO

	50 BEGIN

	51 IDD_VERIFY_CONFIG_DIALOG, DIALOG

	52 BEGIN

	53 LEFTMARGIN, 7

	54 RIGHTMARGIN, 214

	55 VERTGUIDE, 105

	56 VERTGUIDE, 116

	57 VERTGUIDE, 203

	58 TOPMARGIN, 7

	59 BOTTOMMARGIN, 52

	60 END

	61 END

	62 #endif // APSTUDIO_INVOKED

	63

	64 #endif // English (U.S.) resources

	65 /////////////////////////////////////////////////////////////////////////////

OLD	NEW

« no previous file with comments | « no previous file | remoting/host/elevated_controller_module_win.cc » ('j') | remoting/host/elevated_controller_module_win.cc » ('J')