Geolocation support for chromedriver.

Geolocation support for chromedriver, browser-side only.
BUG=chromedriver:14
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133988

[jam, 2012-04-20 23:25:40]

i had meant that we'd convert all users of mock_geolocation.h to
OverrideLocationForTesting() and delete the mock_geolocation completely..

[kkania, 2012-04-21 01:52:49]

On 2012/04/20 23:25:40, John Abd-El-Malek wrote:
> i had meant that we'd convert all users of mock_geolocation.h to
> OverrideLocationForTesting() and delete the mock_geolocation completely..

Whoops, done.

[jam, 2012-04-22 21:30:22]

http://codereview.chromium.org/10070012/diff/10020/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/10070012/diff/10020/content/content_browser.gy...
content/content_browser.gypi:721: 'test/override_geolocation.cc',
sorry I realize I told you to put this in content/test, but I thought about it
more and now realize this isn't the right code. code that ships should only be
including code from content/public. only test  binaries should be including code
from content/test.

so can you put this new function in content/public/browser/geolocation.h. the cc
file can be in content/browser/geolocation/geolocation.cc

[kkania, 2012-04-23 17:27:26]

Moved from test to public.

[jam, 2012-04-24 15:10:14]

http://codereview.chromium.org/10070012/diff/17005/content/browser/geolocatio...
File content/browser/geolocation/geolocation.cc (right):

http://codereview.chromium.org/10070012/diff/17005/content/browser/geolocatio...
content/browser/geolocation/geolocation.cc:24:
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(
nit: per the style guide, the first argument on each line has to start at the
same indentation. i'd write this as:

BrowserThread::PostTask(
    BrowserThread::IO, FROM_HERE,
    base::Bind(
        &OverrideLocationForTesting, latitude, longitude, altitude,
        callback_loop, completion_callback));

http://codereview.chromium.org/10070012/diff/17005/content/public/browser/geo...
File content/public/browser/geolocation.h (right):

http://codereview.chromium.org/10070012/diff/17005/content/public/browser/geo...
content/public/browser/geolocation.h:13: struct Geoposition;
nit: not used

http://codereview.chromium.org/10070012/diff/17005/content/public/browser/geo...
content/public/browser/geolocation.h:31: scoped_refptr<base::MessageLoopProxy>
callback_loop,
nit: can you skip passing in the MLP, and say that the callback will be called
back on the current thread?

[kkania, 2012-04-24 16:50:36]

http://codereview.chromium.org/10070012/diff/17005/content/browser/geolocatio...
File content/browser/geolocation/geolocation.cc (right):

http://codereview.chromium.org/10070012/diff/17005/content/browser/geolocatio...
content/browser/geolocation/geolocation.cc:24:
BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(
On 2012/04/24 15:10:14, John Abd-El-Malek wrote:
> nit: per the style guide, the first argument on each line has to start at the
> same indentation. i'd write this as:
> 
> BrowserThread::PostTask(
>     BrowserThread::IO, FROM_HERE,
>     base::Bind(
>         &OverrideLocationForTesting, latitude, longitude, altitude,
>         callback_loop, completion_callback));

Done.

http://codereview.chromium.org/10070012/diff/17005/content/public/browser/geo...
File content/public/browser/geolocation.h (right):

http://codereview.chromium.org/10070012/diff/17005/content/public/browser/geo...
content/public/browser/geolocation.h:13: struct Geoposition;
On 2012/04/24 15:10:14, John Abd-El-Malek wrote:
> nit: not used

Done.

http://codereview.chromium.org/10070012/diff/17005/content/public/browser/geo...
content/public/browser/geolocation.h:31: scoped_refptr<base::MessageLoopProxy>
callback_loop,
On 2012/04/24 15:10:14, John Abd-El-Malek wrote:
> nit: can you skip passing in the MLP, and say that the callback will be called
> back on the current thread?

Done.

[jam, 2012-04-24 17:12:00]

lgtm

[kkania, 2012-04-24 18:31:21]

joth or jknotten, would either of you like to review before I commit?

[John Knottenbelt, 2012-04-25 10:27:02]

lgtm

[commit-bot: I haz the power, 2012-04-25 18:23:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kkania@chromium.org/10070012/42001

[commit-bot: I haz the power, 2012-04-25 21:48:07]

Change committed as 133988