validator_ragel: Link into TCB, use under env var

src/trusted/validator/ncvalidate.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVALIDATE_H__
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVALIDATE_H__
 
 /* Defines the API to the native client validation code.
@@ skipping 80 matching lines @@
                                               NACL_TARGET_SUBARCH)(
     enum NaClSBKind         sb_kind,
     uintptr_t               guest_addr,
     uint8_t                 *data,
     size_t                  size,
     int                     stubout_mode,
     int                     readonly_text,
     const NaClCPUFeatures   *cpu_features,
     struct NaClValidationCache *cache);
 
+/* Applies the DFA-based validator as in the ApplyValidator case described
+ * above.  The interface of this new validator must remain the same as of the
+ * ApplyValidator.  Less arguments will be ignored as the new validator
+ * implements features, such as stubout mode.
+ */
+extern NaClValidationStatus NACL_SUBARCH_NAME(ApplyDfaValidator,

[Nick Bray, 2012/04/19 23:11:08]

Don't specify this interface into ncvalidate, just pull a headerfile from ragel
into sel_ldr.

[pasko-google - do not use, 2012/04/20 14:30:38]

I did not want to include directly anything from unreviewed/*. Also, ragel
validating function names differ for 32bit and 64bit sandboxes
(ValidateChunkAMD64,ValidateChunkIA32)  to be able to keep them in the same
binary (good for SDK). Pulling directly into platform-independent parts would
require #ifdef-ing. So I rather went with the existing mechanism for handling
platform differences in validator.

+                                              NACL_TARGET_ARCH,
+                                              NACL_TARGET_SUBARCH)(
+    enum NaClSBKind         sb_kind,
+    uintptr_t               guest_addr,
+    uint8_t                 *data,
+    size_t                  size,
+    int                     stubout_mode,
+    int                     readonly_text,
+    const NaClCPUFeatures   *cpu_features,
+    struct NaClValidationCache *cache);
+
 /* Applies the validator, as used in a command-line tool to report issues.
  * Note: This is intentionally separated from ApplyValidator, since it need
  * not be performance critical.
  * Parameters are:
  *    local_cpu: True if local cpu rules should be applied.
  *           Otherwise, assume no cpu specific rules.
  *    guest_addr - The virtual pc to assume with the beginning address of the
  *           code segment. Typically, this is the corresponding addresss that
  *           will be used by objdump.
  *    data - The contents of the code segment to be validated.
@@ skipping 54 matching lines @@
     enum NaClSBKind       sb_kind,
     uintptr_t             guest_addr,
     uint8_t               *data_old,
     uint8_t               *data_new,
     size_t                size,
     const NaClCPUFeatures *cpu_features);
 
 EXTERN_C_END
 
 #endif  /*  NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_X86_NCVALIDATE_H__ */