Add a copy of the Kraken Benchmark for performance testing.

Add a copy of the Kraken Benchmark for performance testing.

This copy was fetched from:
hg.mozilla.org/projects/kraken/

Modifications made:
The python script make-hosted.py was run to update the hosted/ directory, and the unused tests, sunspider, and sunspider-compare-results files were deleted.

BUG=126516
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134624

[sullivan, 2012-04-19 14:18:26]

FYI, I'm doing this change in two parts. 

This patch is the first part: getting a version of the test that can be run
manually with as few modifications as possible. I deleted some directories that
aren't used in running the test. I also ignored lint warnings about the tests
containing whitespace and long lines that don't follow our style guide.

The second part will be to add some small modifications to allow our automation
to detect when the test is finished and get the results, and adding a cc file in
chrome/test/ui to run the test.

[tonyg, 2012-04-19 16:14:34]

> This patch is the first part: getting a version of the test that can be run
> manually with as few modifications as possible. I deleted some directories
that
> aren't used in running the test. I also ignored lint warnings about the tests
> containing whitespace and long lines that don't follow our style guide.

Good idea on the two part approach. While, I know this follows the pattern of
the v8, sunspider, and dromaeo test data, I actually believe we should create a
chrome/test/data/third_party directory and put this in there.

Then we should follow the other guidelines here:
http://www.chromium.org/developers/adding-3rd-party-libraries

Most importantly, add a LICENSE file.

[tonyg, 2012-04-19 16:15:55]

https://chromiumcodereview.appspot.com/10070009/diff/1/chrome/test/data/krake...
File chrome/test/data/kraken/README.chromium (right):

https://chromiumcodereview.appspot.com/10070009/diff/1/chrome/test/data/krake...
chrome/test/data/kraken/README.chromium:9: The python script make-hosted.py was
run to update the hosted/ directory, and the unused tests, sunspider, and
sunspider-compare-results files were deleted.
I still see files for sunspider. Can/should we delete those?

[sullivan, 2012-04-19 17:50:07]

On 2012/04/19 16:14:34, tonyg wrote:
> > This patch is the first part: getting a version of the test that can be run
> > manually with as few modifications as possible. I deleted some directories
> that
> > aren't used in running the test. I also ignored lint warnings about the
tests
> > containing whitespace and long lines that don't follow our style guide.
> 
> Good idea on the two part approach. While, I know this follows the pattern of
> the v8, sunspider, and dromaeo test data, I actually believe we should create
a
> chrome/test/data/third_party directory and put this in there.
> 
> Then we should follow the other guidelines here:
> http://www.chromium.org/developers/adding-3rd-party-libraries
> 
> Most importantly, add a LICENSE file.

I moved it into third_party. But I have a silly question about the license--I
know it must be MPL, but I can't actually find anything to show that at
http://krakenbenchmark.mozilla.org/ or http://hg.mozilla.org/projects/kraken

Is there an easy way to find for certain what the license is?

[sullivan, 2012-04-19 18:41:45]

+Robert Sayrer

Robert, I'm adding Kraken to our performance testing suite in Chromium and I
need to make sure I use the correct license. I can't find the license at
hg.mozilla.org/projects/kraken or at krakenbenchmark.mozilla.org. Is it MPL 2.0?

Thanks,
Annie

https://chromiumcodereview.appspot.com/10070009/diff/1/chrome/test/data/krake...
File chrome/test/data/kraken/README.chromium (right):

https://chromiumcodereview.appspot.com/10070009/diff/1/chrome/test/data/krake...
chrome/test/data/kraken/README.chromium:9: The python script make-hosted.py was
run to update the hosted/ directory, and the unused tests, sunspider, and
sunspider-compare-results files were deleted.
On 2012/04/19 16:15:55, tonyg wrote:
> I still see files for sunspider. Can/should we delete those?

It looks like we can. I'll delete them.

[sullivan, 2012-04-23 14:21:35]

+dmandelin

Hi David,

I want to add the Kraken benchmark to Chromium's performance testing suite. But
I need to make sure I am using the correct license--is it MPL 2.0?

Thanks,
Annie

[dmandelin_mozilla.com, 2012-04-23 17:19:08]

----- Original Message -----
> +dmandelin
> 
> Hi David,
> 
> I want to add the Kraken benchmark to Chromium's performance testing
> suite.
> But
> I need to make sure I am using the correct license--is it MPL 2.0?
> 
> Thanks,
> Annie
> 
> http://codereview.chromium.org/10070009/
> 

Kraken licensing is a mess. Any parts we created are MPL 2.0, but most of the
tests were taken from other sources. A few of the files contain copyright
notices, but not all. Andy Wingo was asking about this a while back for similar
reasons. He spent some time finding the original sources--I copied his email
below. Hope this helps!

Dave



----- Original Message -----
> Greets,
>
> On Tue, 2012-02-28 at 11:50 -0800, David Mandelin wrote:
> > Is there anything we can do short of an archaeology project to try
> > to
> > find the original code on the web for each file?
>
> I think archaeology is the thing, unfortunately :/  And given that
> Kraken has insinuated itself into the JS benchmarking world ;),
> probably
> sooner is better than later.
>
> I'll take an initial look:
>
> ai-astar.js
> ai-astar-data.js
>
>         Seems based off of
>         https://github.com/bgrins/javascript-astar.
>         MIT license.  Some modifications to the harness, presumably
>         by
>         Rob.  The -data includes code (ugh).
>        
> audio-beat-detection.js
> audio-beat-detection-data.js
> audio-dft.js
> audio-dft-data.js
> audio-fft.js
> audio-fft-data.js
> audio-oscillator.js
> audio-oscillator-data.js
>        
>         All of these -data actually include a bunch of code, with
>         this
>         copyright block:
>        
>         /*
>          *  DSP.js - a comprehensive digital signal processing
>           library
>         for javascript
>          *
>          *  Created by Corban Brook <corbanbrook@gmail.com> on
>         2010-01-01.
>          *  Copyright 2010 Corban Brook. All rights reserved.
>          *
>          */
>        
>         However: https://github.com/corbanbrook/dsp.js/#readme notes
>         an
>         MIT license.
>        
>         Otherwise, the additional code around this is fairly minimal,
>         and it would probably be OK to assume that it is MPL.
>
> imaging-darkroom.js
> imaging-darkroom-data.js
>
>         Derived from
>         http://hacks.mozilla.org/2010/08/fun-with-fast-javascript/
>         which itself was derived from
>        
http://nativeclient.googlecode.com/svn-history/r232/trunk/nacl/googleclient/n...
>        
>         under a permissive license.
>        
> imaging-desaturate.js
>
>         An actual licensing block!
>         /*
>          * Pixastic Lib - Desaturation filter - v0.1.1
>          * Copyright (c) 2008 Jacob Seidelin, jseidelin@nihilogic.dk,
>         http://blog.nihilogic.dk/
>          * License: [http://www.pixastic.com/lib/license.txt] (MPL
>          1.1)
>          */
>
> imaging-gaussian-blur.js
>
>         Appears to be derived from processing.js, specifically:
>        
https://github.com/jeresig/processing-js/blob/master/test/ref/index.html
>
> json-parse-financial.js
>        
>         Trivial, just tests JSON.parse
>        
> json-stringify-tinderbox.js
>
>         again, trivial
>
> stanford-crypto-aes.js
> stanford-crypto-ccm.js
> stanford-crypto-pbkdf2.js
> stanford-crypto-sha256-iterative.js
>
>         http://crypto.stanford.edu/sjcl/, dual-licensed BSD or
>         GPLv2+.
>         The GPL license appears to be so that they can use some
>         patents
>         that are freely licensed for "OCB".  The sjcl code included
>         here
>         does include the ocb code.
>
> OK, so I'm not sure if I've spent these 45 minutes productively or
> not ;-)  If you are satisfied with this analysis, I'll send a
> COPYRIGHT
> file to commit to kraken-1.1/.  Let me know.

[sullivan, 2012-04-24 14:46:36]

+ open-source-third-party-reviews@google.com

Thanks, David!


open-source-third-party-reviews@google.com: See David's previous mail, there are
multiple licenses in the code. How should I format README.chromium and LICENSE
to account for that?

Thanks,
Annie

[sullivan, 2012-04-30 19:16:31]

I chatted with folks from open source third party reviews offline, and the right
thing to do here is put "various" in README.chromium, and concatenate all the
licenses together in the LICENSE file. This is ready for review now.

[cmp, 2012-04-30 20:54:29]

lgtm

[commit-bot: I haz the power, 2012-04-30 21:00:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sullivan@chromium.org/10070009/23002

[commit-bot: I haz the power, 2012-04-30 22:50:35]

Change committed as 134624