Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2981)

Unified Diff: chrome/nacl/nacl_ipc_adapter.h

Issue 10069051: RefCounted types should not have public destructors, chrome/nacl edition (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/nacl/nacl_ipc_adapter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/nacl/nacl_ipc_adapter.h
diff --git a/chrome/nacl/nacl_ipc_adapter.h b/chrome/nacl/nacl_ipc_adapter.h
index f8e8733e39255f86a1fa5704f2c8d7dc3f51f25b..e28c0422819cd55d82e383474bbe1a0c713b4d7b 100644
--- a/chrome/nacl/nacl_ipc_adapter.h
+++ b/chrome/nacl/nacl_ipc_adapter.h
@@ -59,8 +59,6 @@ class NaClIPCAdapter : public base::RefCountedThreadSafe<NaClIPCAdapter>,
// purposes. This function will take ownership of the given channel.
NaClIPCAdapter(scoped_ptr<IPC::Channel> channel, base::TaskRunner* runner);
- virtual ~NaClIPCAdapter();
-
// Implementation of sendmsg. Returns the number of bytes written or -1 on
// failure.
int Send(const char* input_data, size_t input_data_len);
@@ -79,6 +77,8 @@ class NaClIPCAdapter : public base::RefCountedThreadSafe<NaClIPCAdapter>,
virtual void OnChannelError() OVERRIDE;
private:
+ friend class base::RefCountedThreadSafe<NaClIPCAdapter>;
+
class RewrittenMessage;
// This is the data that must only be accessed inside the lock. This struct
@@ -112,6 +112,8 @@ class NaClIPCAdapter : public base::RefCountedThreadSafe<NaClIPCAdapter>,
scoped_ptr<IPC::Channel> channel_;
};
+ virtual ~NaClIPCAdapter();
+
// Reads up to the given amount of data. Returns 0 if nothing is waiting.
int LockedReceive(char* output_buffer, int output_buffer_size);
« no previous file with comments | « no previous file | chrome/nacl/nacl_ipc_adapter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698