Issue 10069051: RefCounted types should not have public destructors, chrome/nacl edition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10069051: RefCounted types should not have public destructors, chrome/nacl edition (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi

Modified:
8 years, 8 months ago

Reviewers:
nduca, brettw

CC:
chromium-reviews, native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

RefCounted types should not have public destructors, chrome/nacl edition Additionally, convert a scoped_ptr<> to a scoped_refptr<> BUG=123295 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134186

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -15 lines)			Patch
M	chrome/nacl/nacl_ipc_adapter.h	View		3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/nacl/nacl_ipc_adapter.cc	View	1	5 chunks	+14 lines, -11 lines	0 comments	Download
M	chrome/nacl/nacl_listener.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/nacl/nacl_listener.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (0 generated)

nduca

Not sure why I'm reviewer for this. Definitely not an owner in this area of ...

8 years, 8 months ago (2012-04-17 04:25:59 UTC) #3

Ryan Sleevi

nduca: git blame on the line, that's why you got roped in. Brett, would you ...

8 years, 8 months ago (2012-04-26 17:24:49 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10069051/5001

8 years, 8 months ago (2012-04-26 21:42:31 UTC) #6

Change committed as 134186