PPAPI: Compile out thread checks when pepper threading is turned on.

PPAPI: Compile out thread checks when pepper threading is turned on.

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132197

[yzshen1, 2012-04-12 22:21:23]

http://codereview.chromium.org/10069032/diff/1/ppapi/proxy/plugin_var_tracker.cc
File ppapi/proxy/plugin_var_tracker.cc (right):

http://codereview.chromium.org/10069032/diff/1/ppapi/proxy/plugin_var_tracker...
ppapi/proxy/plugin_var_tracker.cc:20: #define CHECK_VALID_THREAD() do {
CalledOnValidThread(); } while(false)
- We need to DCHECK the result of CalledOnValidThread().

- [optional] The other way is to derive the var tracker from
NonThreadSafeDoNothing if ENABLE_PEPPER_THREADING. And then
DCHECK(CalledOnValidThread()) can be used for both cases. It seems better to me
because we don't have to duplicate the definition of CHECK_VALID_THREAD in three
files.

http://codereview.chromium.org/10069032/diff/1/ppapi/shared_impl/var_tracker.cc
File ppapi/shared_impl/var_tracker.cc (right):

http://codereview.chromium.org/10069032/diff/1/ppapi/shared_impl/var_tracker....
ppapi/shared_impl/var_tracker.cc:18: #define CHECK_VALID_THREAD() do {
CalledOnValidThread(); } while(false)
We need to DCHECK the result of CalledOnValidThread().

http://codereview.chromium.org/10069032/diff/1/webkit/plugins/ppapi/host_var_...
File webkit/plugins/ppapi/host_var_tracker.cc (right):

http://codereview.chromium.org/10069032/diff/1/webkit/plugins/ppapi/host_var_...
webkit/plugins/ppapi/host_var_tracker.cc:19: #define CHECK_VALID_THREAD() do {
CalledOnValidThread(); } while(false)
We need to DCHECK the result of CalledOnValidThread().

[dmichael (off chromium), 2012-04-12 22:39:27]

Thanks. Sorry for the missing DCHECKs; that was just a mistake.

I went with your suggestion of using NotThreadSafeDoNothing...  I had avoided
because it has a comment that you should "almost always" use NotThreadSafe.
Maybe this kind of case is the "almost".

[yzshen1, 2012-04-12 22:47:14]

lgtm

Thanks!

[commit-bot: I haz the power, 2012-04-13 02:31:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10069032/6001

[commit-bot: I haz the power, 2012-04-13 05:18:11]

Try job failure for 10069032-6001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-13 14:43:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10069032/6001

[commit-bot: I haz the power, 2012-04-13 16:06:12]

Change committed as 132197