Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10069031: Replace SafeBrowsing MAC with downloads over SSL. (Closed)

Created:
8 years, 8 months ago by Brian Ryner
Modified:
8 years, 8 months ago
Reviewers:
Garrett Casto, mattm
CC:
chromium-reviews, noelutz
Visibility:
Public.

Description

Replace SafeBrowsing MAC with downloads over SSL. BUG=119662 TEST=updated unittests, ran Chrome and verified SB functionality on new profile Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132456

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -846 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.h View 11 chunks +15 lines, -53 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager.cc View 21 chunks +32 lines, -135 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_manager_unittest.cc View 11 chunks +29 lines, -80 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.h View 2 chunks +2 lines, -20 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser.cc View 8 chunks +1 line, -116 lines 0 comments Download
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 26 chunks +31 lines, -293 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.h View 3 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 6 chunks +10 lines, -51 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_test.cc View 8 chunks +5 lines, -18 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.h View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 3 chunks +0 lines, -37 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Brian Ryner
We're still waiting on one outstanding server-side question before this will be ready to submit, ...
8 years, 8 months ago (2012-04-12 22:05:38 UTC) #1
mattm
lgtm
8 years, 8 months ago (2012-04-14 03:17:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/10069031/1
8 years, 8 months ago (2012-04-16 19:00:09 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 21:22:20 UTC) #4 
Change committed as 132456

Powered by Google App Engine
This is Rietveld 408576698