Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 10069026: Bundle Flapper binaries on Windows. (Closed)

Created:
8 years, 8 months ago by viettrungluu
Modified:
8 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Bundle Flapper binaries on Windows. This does not enable the use of the bundled Flapper. This is dependent on http://codereview.chromium.org/10067013/ . Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/installer/mini_installer/chrome.release View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
viettrungluu
(See also http://codereview.chromium.org/10067013/ , which is a prerequisite for this patch.) Is there anything else ...
8 years, 8 months ago (2012-04-12 20:18:20 UTC) #1
viettrungluu
On 2012/04/12 20:18:20, viettrungluu wrote: > (See also http://codereview.chromium.org/10067013/ , which is a prerequisite for ...
8 years, 8 months ago (2012-04-13 00:35:59 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm but wait for an ok from robert or greg. There might be an issue ...
8 years, 8 months ago (2012-04-13 00:41:40 UTC) #3
robertshield
On 2012/04/13 00:41:40, cpu wrote: > lgtm but wait for an ok from robert or ...
8 years, 8 months ago (2012-04-13 00:51:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/10069026/1
8 years, 8 months ago (2012-04-13 16:13:30 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 18:43:44 UTC) #6
Change committed as 132226

Powered by Google App Engine
This is Rietveld 408576698