Log Gaia response codes to ease diagnostics of networking issues.

Log Gaia response codes and Gaia-related networking activity to ease diagnostics of Gaia issues.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132493

[alexeypa (please no reviews), 2012-04-12 18:10:18]

PTAL.

[Jamie, 2012-04-12 18:20:20]

lgtm with a couple of suggestions.

https://chromiumcodereview.appspot.com/10069020/diff/1/remoting/host/gaia_oau...
File remoting/host/gaia_oauth_client.cc (right):

https://chromiumcodereview.appspot.com/10069020/diff/1/remoting/host/gaia_oau...
remoting/host/gaia_oauth_client.cc:138: VLOG(1) << "Gaia response: response
code=net::HTTP_BAD_REQUEST.";
I think I would lean towards using LOG(ERROR) in this case. We really don't
expect this to happen under normal circumstances.

https://chromiumcodereview.appspot.com/10069020/diff/1/remoting/host/gaia_oau...
remoting/host/gaia_oauth_client.cc:161: VLOG(1) << "Gaia response: response
code=" << source->GetResponseCode();
Also LOG(ERROR), just for the "else" clause.

[commit-bot: I haz the power, 2012-04-12 19:26:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10069020/5001

[commit-bot: I haz the power, 2012-04-12 20:08:42]

Try job failure for 10069020-5001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[alexeypa (please no reviews), 2012-04-12 23:25:30]

+sergeyu

I have added logging of Gaia-related networking activity to VLOG(4). Could you
please take a look?

[Sergey Ulanov, 2012-04-13 00:55:32]

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
File remoting/host/dev_net_log.cc (right):

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.cc:27: 
Don't need this empty line.

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
File remoting/host/dev_net_log.h (right):

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:13: class DevNetLog : public net::NetLog {
Add comments to explain what this is for.

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:13: class DevNetLog : public net::NetLog {
Can we have better name? E.g. NullNetLog

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:16: ~DevNetLog();
virtual

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:27: LogLevel log_level);
mark this and two methods below as OVERRIDE.

[alexeypa (please no reviews), 2012-04-13 18:28:22]

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
File remoting/host/dev_net_log.cc (right):

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.cc:27: 
On 2012/04/13 00:55:33, sergeyu wrote:
> Don't need this empty line.

Done.

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
File remoting/host/dev_net_log.h (right):

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:13: class DevNetLog : public net::NetLog {
On 2012/04/13 00:55:33, sergeyu wrote:
> Can we have better name? E.g. NullNetLog

Done.

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:13: class DevNetLog : public net::NetLog {
On 2012/04/13 00:55:33, sergeyu wrote:
> Add comments to explain what this is for.

Done.

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:16: ~DevNetLog();
On 2012/04/13 00:55:33, sergeyu wrote:
> virtual

Done.

https://chromiumcodereview.appspot.com/10069020/diff/1003/remoting/host/dev_n...
remoting/host/dev_net_log.h:27: LogLevel log_level);
On 2012/04/13 00:55:33, sergeyu wrote:
> mark this and two methods below as OVERRIDE.

Done.

[alexeypa (please no reviews), 2012-04-16 19:25:36]

ping

[Sergey Ulanov, 2012-04-16 20:15:16]

lgtm

https://chromiumcodereview.appspot.com/10069020/diff/16001/remoting/host/vlog...
File remoting/host/vlog_net_log.h (right):

https://chromiumcodereview.appspot.com/10069020/diff/16001/remoting/host/vlog...
remoting/host/vlog_net_log.h:38: };
DISALLOW_COPY_AND_ASSING

[Jamie, 2012-04-16 20:16:39]

https://chromiumcodereview.appspot.com/10069020/diff/16001/remoting/host/vlog...
File remoting/host/vlog_net_log.h (right):

https://chromiumcodereview.appspot.com/10069020/diff/16001/remoting/host/vlog...
remoting/host/vlog_net_log.h:38: };
On 2012/04/16 20:15:16, sergeyu wrote:
> DISALLOW_COPY_AND_ASSING

ASSIGN :)

[alexeypa (please no reviews), 2012-04-16 20:21:16]

https://chromiumcodereview.appspot.com/10069020/diff/16001/remoting/host/vlog...
File remoting/host/vlog_net_log.h (right):

https://chromiumcodereview.appspot.com/10069020/diff/16001/remoting/host/vlog...
remoting/host/vlog_net_log.h:38: };
On 2012/04/16 20:15:16, sergeyu wrote:
> DISALLOW_COPY_AND_ASSING

Done.

[commit-bot: I haz the power, 2012-04-16 20:21:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10069020/26001

[commit-bot: I haz the power, 2012-04-16 21:08:25]

Try job failure for 10069020-26001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-04-16 21:47:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10069020/22004

[commit-bot: I haz the power, 2012-04-17 00:34:12]

Change committed as 132493