Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Unified Diff: content/browser/download/save_package.h

Issue 10069016: TabContents -> WebContentsImpl, part 9. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/save_file_manager.cc ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/save_package.h
diff --git a/content/browser/download/save_package.h b/content/browser/download/save_package.h
index 9fa5d87d18e7b07a68c1627ca73506b6f505af44..8fefebd7ed5ae2d1a06ea037644100afc972c56e 100644
--- a/content/browser/download/save_package.h
+++ b/content/browser/download/save_package.h
@@ -45,7 +45,7 @@ class WebContents;
// Each page saving job may include one or multiple files which need to be
// saved. Each file is represented by a SaveItem, and all SaveItems are owned
// by the SavePackage. SaveItems are created when a user initiates a page
-// saving job, and exist for the duration of one tab's life time.
+// saving job, and exist for the duration of one contents's life time.
class CONTENT_EXPORT SavePackage
: public base::RefCountedThreadSafe<SavePackage>,
public content::WebContentsObserver,
@@ -74,7 +74,7 @@ class CONTENT_EXPORT SavePackage
// Constructor for user initiated page saving. This constructor results in a
// SavePackage that will generate and sanitize a suggested name for the user
// in the "Save As" dialog box.
- explicit SavePackage(content::WebContents* tab_contents);
+ explicit SavePackage(content::WebContents* web_contents);
// This contructor is used only for testing. We can bypass the file and
// directory name generation / sanitization by providing well known paths
@@ -109,7 +109,7 @@ class CONTENT_EXPORT SavePackage
bool canceled() const { return user_canceled_ || disk_error_occurred_; }
bool finished() const { return finished_; }
content::SavePageType save_type() const { return save_type_; }
- int tab_id() const { return tab_id_; }
+ int contents_id() const { return contents_id_; }
int id() const { return unique_id_; }
content::WebContents* web_contents() const;
@@ -294,9 +294,9 @@ class CONTENT_EXPORT SavePackage
// from outside.
WaitState wait_state_;
- // Since for one tab, it can only have one SavePackage in same time.
- // Now we actually use render_process_id as tab's unique id.
- const int tab_id_;
+ // Since for one contents, it can only have one SavePackage in same time.
+ // Now we actually use render_process_id as the contents's unique id.
+ const int contents_id_;
// Unique ID for this SavePackage.
const int unique_id_;
« no previous file with comments | « content/browser/download/save_file_manager.cc ('k') | content/browser/download/save_package.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698