Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.cc

Issue 10069014: Save Page As MHTML (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cros Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/download/save_package_file_picker.h » ('j') | chrome/browser/download/save_package_file_picker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/chrome_download_manager_delegate.cc
diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc
index 65e42702d0cf8fedc400cb577aef16e11f7b7767..fb79abc7fab1e6f64f1ed33bf960141c0c279ce4 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.cc
+++ b/chrome/browser/download/chrome_download_manager_delegate.cc
@@ -355,10 +355,7 @@ void ChromeDownloadManagerDelegate::ChooseSavePath(
content::SaveFilePathPickedCallback callback) {
// Deletes itself.
#if defined(OS_CHROMEOS)
- // Note that we're ignoring the callback here.
- // SavePackageFilePickerChromeOS completes the save operation itself.
- // TODO(achuith): Fix this.
- new SavePackageFilePickerChromeOS(web_contents, suggested_path);
+ new SavePackageFilePickerChromeOS(web_contents, suggested_path, callback);
#else
new SavePackageFilePicker(web_contents, suggested_path, default_extension,
can_save_as_complete, download_prefs_.get(), callback);
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/download/save_package_file_picker.h » ('j') | chrome/browser/download/save_package_file_picker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698