Save Page As MHTML

chrome/browser/download/chrome_download_manager_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
 #define CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_
 #pragma once
 
 #include "base/compiler_specific.h"
 #include "base/hash_tables.h"
@@ skipping 65 matching lines @@
       base::Time remove_begin,
       base::Time remove_end) OVERRIDE;
   virtual void GetSaveDir(content::WebContents* web_contents,
                           FilePath* website_save_dir,
                           FilePath* download_save_dir) OVERRIDE;
   virtual void ChooseSavePath(
       content::WebContents* web_contents,
       const FilePath& suggested_path,
       const FilePath::StringType& default_extension,
       bool can_save_as_complete,
-      content::SaveFilePathPickedCallback callback) OVERRIDE;
+      const content::SaveFilePathPickedCallback& callback) OVERRIDE;
 
   DownloadPrefs* download_prefs() { return download_prefs_.get(); }
   DownloadHistory* download_history() { return download_history_.get(); }
 
+#if defined(ENABLE_SAFE_BROWSING)
+  static void DisableSafeBrowsing(content::DownloadItem* item);
+#endif

[Randy Smith (Not in Mondays), 2012/04/27 18:24:04]

It looks like CDMD has to date only used ifdefs to null out subsections of code
rather than whole function APIs.  If Noe' et al have an opinion, it should be
followed, but in the absence of this are you willing to declare this function
but make its behavior null if Safe browsing isn't defined, similar to
GetDownloadProtectionService?

[benjhayden, 2012/04/30 13:37:19]

Done.

+
  protected:
   // So that test classes can inherit from this for override purposes.
   virtual ~ChromeDownloadManagerDelegate();
 
   // So that test classes that inherit from this for override purposes
   // can call back into the DownloadManager.
   scoped_refptr<content::DownloadManager> download_manager_;
 
  private:
   friend class base::RefCountedThreadSafe<ChromeDownloadManagerDelegate>;
@@ skipping 60 matching lines @@
   // Maps from pending extension installations to DownloadItem IDs.
   typedef base::hash_map<CrxInstaller*, int> CrxInstallerMap;
   CrxInstallerMap crx_installers_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeDownloadManagerDelegate);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_CHROME_DOWNLOAD_MANAGER_DELEGATE_H_