Save Page As MHTML

chrome/browser/download/save_package_file_picker.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_
 #define CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_
 #pragma once
 
-#include "base/callback.h"
 #include "base/memory/ref_counted.h"
 #include "chrome/browser/ui/select_file_dialog.h"
 #include "content/public/browser/download_manager_delegate.h"
 
 class DownloadPrefs;
 
 // Handles showing a dialog to the user to ask for the filename to save a page.
 class SavePackageFilePicker : public SelectFileDialog::Listener {
  public:
   SavePackageFilePicker(content::WebContents* web_contents,
-                        const FilePath& suggested_path,

[asanka, 2012/04/26 16:06:20]

Why do this? This will trigger a Coverity warning.

[benjhayden, 2012/04/26 16:33:36]

Which/what kind of warning? Can you elaborate?

[asanka, 2012/04/26 18:15:25]

The warning is "Big parameter passed by value". Grep for "pass by value" through
the commit logs and you'll see people converting these to const refs.

The fact that this might trigger a warning, by itself, isn't a reason to avoid
passing by value. But chances are people are going to see those warnings and
they are going to spend time trying to address it.

If you really want to go this route, I think it would be helpful to have a
comment here explaining why.

[benjhayden, 2012/04/26 19:00:48]

Done.

-                        const FilePath::StringType& default_extension,
+                        FilePath suggested_path,
+                        FilePath::StringType default_extension,
                         bool can_save_as_complete,
                         DownloadPrefs* download_prefs,
                         content::SaveFilePathPickedCallback callback);
   virtual ~SavePackageFilePicker();
 
   // Used to disable prompting the user for a directory/filename of the saved
   // web page.  This is available for testing.
   static void SetShouldPromptUser(bool should_prompt);
 
  private:
   // SelectFileDialog::Listener implementation.
   virtual void FileSelected(const FilePath& path,
                             int index,
-                            void* params) OVERRIDE;
-  virtual void FileSelectionCanceled(void* params) OVERRIDE;
+                            void* unused_params) OVERRIDE;
+  virtual void FileSelectionCanceled(void* unused_params) OVERRIDE;
+
+  bool ShouldSaveAsMHTML() const;
 
   // Used to look up the renderer process for this request to get the context.
   int render_process_id_;
 
+  // Whether the web page can be saved as a complete HTML file.
+  bool can_save_as_complete_;
+
   content::SaveFilePathPickedCallback callback_;
 
   // For managing select file dialogs.
   scoped_refptr<SelectFileDialog> select_file_dialog_;
 
   DISALLOW_COPY_AND_ASSIGN(SavePackageFilePicker);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_SAVE_PACKAGE_FILE_PICKER_H_