Save Page As MHTML

content/browser/download/download_manager_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_manager_impl.h"
 
 #include <iterator>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 426 matching lines @@
   downloads_.insert(download);
   active_downloads_[download_id] = download;
 
   return bound_net_log;
 }
 
 DownloadItem* DownloadManagerImpl::CreateSavePackageDownloadItem(
     const FilePath& main_file_path,
     const GURL& page_url,
     bool is_otr,
+    const std::string& mime_type,
     DownloadItem::Observer* observer) {
   net::BoundNetLog bound_net_log =
       net::BoundNetLog::Make(net_log_, net::NetLog::SOURCE_DOWNLOAD);
   DownloadItem* download = new DownloadItemImpl(
-      this, main_file_path, page_url, is_otr, GetNextId(), bound_net_log);
+      this,
+      main_file_path,
+      page_url,
+      is_otr,
+      GetNextId(),
+      mime_type,
+      bound_net_log);
 
   download->AddObserver(observer);
 
   DCHECK(!ContainsKey(save_page_downloads_, download->GetId()));
   downloads_.insert(download);
   save_page_downloads_[download->GetId()] = download;
 
   // Will notify the observer in the callback.
   delegate_->AddItemToPersistentStore(download);
 
@@ skipping 149 matching lines @@
 
   // If the download hasn't been inserted into the history system
   // (which occurs strictly after file name determination, intermediate
   // file rename, and UI display) then it's not ready for completion.
   if (!download->IsPersisted())
     return false;
 
   return true;
 }
 
+// When SavePackage downloads MHTML to GData (see
+// SavePackageFilePickerChromeOS), GData calls MaybeCompleteDownload() like it
+// does for non-SavePackage downloads, but SavePackage downloads never satisfy
+// IsDownloadReadyForCompletion(). GDataDownloadObserver manually calls
+// DownloadItem::UpdateObservers() when the upload completes so that SavePackage
+// notices that the upload has completed and runs its normal Finish() pathway.
+// MaybeCompleteDownload() is never the mechanism by which SavePackage completes
+// downloads. SavePackage always uses its own Finish() to mark downloads
+// complete.

[Randy Smith (Not in Mondays), 2012/04/27 18:24:04]

Is there a way to do this via callback so that we don't have to be resilient to
a pretty arbitrary call to a random method (at least, it's random in the
SavePackage context).

[benjhayden, 2012/04/28 19:09:03]

SavePackage could pass base::Bind(&SavePackage::MaybeFinish) to
delegate()->ChooseSavePath(), CDMD could give that callback to
GDataDownloadObserver, GDataDownloadObserver could store that callback in a map.

I thought that adding a map to GDataDownloadObserver would be unnecessarily
heavy and sketchy in an already heavy, sketchy CL, but I can try it if you want.

+
 void DownloadManagerImpl::MaybeCompleteDownload(DownloadItem* download) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   VLOG(20) << __FUNCTION__ << "()" << " download = "
            << download->DebugString(false);
 
   if (!IsDownloadReadyForCompletion(download))
     return;
 
   // TODO(rdsmith): DCHECK that we only pass through this point
   // once per download.  The natural way to do this is by a state
@@ skipping 577 matching lines @@
     if (it->second->IsComplete() && !it->second->GetOpened())
       ++num_unopened;
   }
   download_stats::RecordOpensOutstanding(num_unopened);
 }
 
 void DownloadManagerImpl::SetFileManagerForTesting(
       DownloadFileManager* file_manager) {
   file_manager_ = file_manager;
 }