Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: content/browser/renderer_host/media/audio_renderer_host_unittest.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/audio_renderer_host_unittest.cc
diff --git a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
index 6a1287a0b59329725f4cfe92dc34a2dec4125bdf..ca6940c8b661239621cbece0f2a16b31bc431a64 100644
--- a/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
+++ b/content/browser/renderer_host/media/audio_renderer_host_unittest.cc
@@ -49,11 +49,6 @@ class MockAudioRendererHost : public AudioRendererHost {
shared_memory_length_(0) {
}
- virtual ~MockAudioRendererHost() {
- // Make sure all audio streams have been deleted.
- EXPECT_EQ(0u, audio_entries_.size());
- }
-
// A list of mock methods.
MOCK_METHOD2(OnStreamCreated,
void(int stream_id, int length));
@@ -68,6 +63,11 @@ class MockAudioRendererHost : public AudioRendererHost {
base::SyncSocket* sync_socket() { return sync_socket_.get(); }
private:
+ virtual ~MockAudioRendererHost() {
+ // Make sure all audio streams have been deleted.
+ EXPECT_EQ(0u, audio_entries_.size());
sky 2012/04/27 15:45:23 nit: empty
+ }
+
// This method is used to dispatch IPC messages to the renderer. We intercept
// these messages here and dispatch to our mock methods to verify the
// conversation between this object and the renderer.
« no previous file with comments | « content/browser/profiler_message_filter.cc ('k') | content/browser/renderer_host/media/media_stream_device_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698