content/browser/geolocation/arbitrator_dependency_factories_for_test.h - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/arbitrator_dependency_factories_for_test.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/fileapi_message_filter.cc ('k') | content/browser/geolocation/arbitrator_dependency_factories_for_test.cc » ('j') | content/browser/renderer_host/media/audio_renderer_host_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/arbitrator_dependency_factories_for_test.h

diff --git a/content/browser/geolocation/arbitrator_dependency_factories_for_test.h b/content/browser/geolocation/arbitrator_dependency_factories_for_test.h

index 8e0e18fd74752c9eddfca19f2b73e4b880a3b1ae..55e412c2cb7b302682acb50fcd6132528cf198c3 100644

--- a/content/browser/geolocation/arbitrator_dependency_factories_for_test.h

+++ b/content/browser/geolocation/arbitrator_dependency_factories_for_test.h

@@ -15,7 +15,6 @@ class GeolocationArbitratorDependencyFactoryWithLocationProvider

GeolocationArbitratorDependencyFactoryWithLocationProvider(

LocationProviderFactoryFunction factory_function);

- virtual ~GeolocationArbitratorDependencyFactoryWithLocationProvider();

virtual LocationProviderBase* NewNetworkLocationProvider(

content::AccessTokenStore* access_token_store,

@@ -26,6 +25,8 @@ class GeolocationArbitratorDependencyFactoryWithLocationProvider

virtual LocationProviderBase* NewSystemLocationProvider() OVERRIDE;

protected:

+ virtual ~GeolocationArbitratorDependencyFactoryWithLocationProvider();

LocationProviderFactoryFunction factory_function_;

};