Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1662)

Unified Diff: content/browser/download/download_net_log_parameters.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation ordering Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_net_log_parameters.h
diff --git a/content/browser/download/download_net_log_parameters.h b/content/browser/download/download_net_log_parameters.h
index c52b87e5bfab8444d2a065d4bdfc78b7a4b64e5b..d62a8d07f78b1ba80635e72c6f6ae14df43d00aa 100644
--- a/content/browser/download/download_net_log_parameters.h
+++ b/content/browser/download/download_net_log_parameters.h
@@ -31,10 +31,11 @@ class ItemActivatedParameters : public net::NetLog::EventParameters {
content::DownloadDangerType danger_type,
content::DownloadItem::SafetyState safety_state,
int64 start_offset);
- virtual ~ItemActivatedParameters();
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemActivatedParameters();
+
const DownloadType type_;
const int64 id_;
const std::string original_url_;
@@ -55,6 +56,8 @@ class ItemCheckedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemCheckedParameters();
+
const content::DownloadDangerType danger_type_;
const content::DownloadItem::SafetyState safety_state_;
@@ -68,6 +71,8 @@ class ItemInHistoryParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemInHistoryParameters();
+
const int64 db_handle_;
DISALLOW_COPY_AND_ASSIGN(ItemInHistoryParameters);
@@ -80,6 +85,8 @@ class ItemUpdatedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemUpdatedParameters();
+
const int64 bytes_so_far_;
DISALLOW_COPY_AND_ASSIGN(ItemUpdatedParameters);
@@ -93,6 +100,8 @@ class ItemRenamedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemRenamedParameters();
+
const std::string old_filename_;
const std::string new_filename_;
@@ -108,6 +117,8 @@ class ItemInterruptedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemInterruptedParameters();
+
const content::DownloadInterruptReason reason_;
const int64 bytes_so_far_;
const std::string hash_state_;
@@ -122,6 +133,8 @@ class ItemFinishedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemFinishedParameters();
+
const int64 bytes_so_far_;
const std::string final_hash_;
@@ -135,6 +148,8 @@ class ItemCanceledParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~ItemCanceledParameters();
+
const int64 bytes_so_far_;
const std::string hash_state_;
@@ -149,6 +164,8 @@ class FileOpenedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~FileOpenedParameters();
+
const std::string file_name_;
const int64 start_offset_;
@@ -163,6 +180,8 @@ class FileRenamedParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~FileRenamedParameters();
+
const std::string old_filename_;
const std::string new_filename_;
@@ -176,6 +195,8 @@ class FileErrorParameters : public net::NetLog::EventParameters {
virtual base::Value* ToValue() const OVERRIDE;
private:
+ virtual ~FileErrorParameters();
+
const std::string operation_;
const net::Error net_error_;

Powered by Google App Engine
This is Rietveld 408576698