content/browser/appcache/appcache_dispatcher_host.cc - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/appcache/appcache_dispatcher_host.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation ordering Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/appcache/appcache_dispatcher_host.h ('k') | content/browser/appcache/chrome_appcache_service.h » ('j') | content/browser/renderer_host/media/audio_renderer_host_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/appcache/appcache_dispatcher_host.cc

diff --git a/content/browser/appcache/appcache_dispatcher_host.cc b/content/browser/appcache/appcache_dispatcher_host.cc

index 0ac5d9480d06bf27d2010ba9b0d4db03c2bd28fe..71ac30789106931b5bfec2c4d30acf3465b4fc9d 100644

--- a/content/browser/appcache/appcache_dispatcher_host.cc

+++ b/content/browser/appcache/appcache_dispatcher_host.cc

@@ -21,8 +21,6 @@ AppCacheDispatcherHost::AppCacheDispatcherHost(

process_id_(process_id) {

}

-AppCacheDispatcherHost::~AppCacheDispatcherHost() {}

void AppCacheDispatcherHost::OnChannelConnected(int32 peer_pid) {

BrowserMessageFilter::OnChannelConnected(peer_pid);

if (appcache_service_.get()) {

@@ -64,6 +62,8 @@ bool AppCacheDispatcherHost::OnMessageReceived(const IPC::Message& message,

return handled;

}

+AppCacheDispatcherHost::~AppCacheDispatcherHost() {}

void AppCacheDispatcherHost::BadMessageReceived() {

content::RecordAction(UserMetricsAction("BadMessageTerminate_ACDH"));

BrowserMessageFilter::BadMessageReceived();