Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2034)

Unified Diff: content/browser/speech/speech_recognizer_impl.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/speech/speech_recognizer_impl.h ('k') | content/browser/trace_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/speech/speech_recognizer_impl.cc
diff --git a/content/browser/speech/speech_recognizer_impl.cc b/content/browser/speech/speech_recognizer_impl.cc
index d8b765f8f9a945bc17303584341f02b5ee881bf7..d80ae1a6377c1872a19f03fa1592f76ef78ab10d 100644
--- a/content/browser/speech/speech_recognizer_impl.cc
+++ b/content/browser/speech/speech_recognizer_impl.cc
@@ -130,10 +130,6 @@ SpeechRecognizerImpl::SpeechRecognizerImpl(
recognition_engine_->set_delegate(this);
}
-SpeechRecognizerImpl::~SpeechRecognizerImpl() {
- endpointer_.EndSession();
-}
-
// ------- Methods that trigger Finite State Machine (FSM) events ------------
// NOTE:all the external events and requests should be enqueued (PostTask), even
@@ -175,6 +171,15 @@ bool SpeechRecognizerImpl::IsCapturingAudio() const {
return is_capturing_audio;
}
+const SpeechRecognitionEngine&
+SpeechRecognizerImpl::recognition_engine() const {
+ return *(recognition_engine_.get());
+}
+
+SpeechRecognizerImpl::~SpeechRecognizerImpl() {
+ endpointer_.EndSession();
+}
+
// Invoked in the audio thread.
void SpeechRecognizerImpl::OnError(AudioInputController* controller,
int error_code) {
@@ -622,11 +627,6 @@ void SpeechRecognizerImpl::UpdateSignalAndNoiseLevels(const float& rms,
session_id_, clip_detected ? 1.0f : audio_level_, noise_level);
}
-const SpeechRecognitionEngine&
- SpeechRecognizerImpl::recognition_engine() const {
- return *(recognition_engine_.get());
-}
-
void SpeechRecognizerImpl::SetAudioManagerForTesting(
AudioManager* audio_manager) {
testing_audio_manager_ = audio_manager;
« no previous file with comments | « content/browser/speech/speech_recognizer_impl.h ('k') | content/browser/trace_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698