Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: content/browser/resolve_proxy_msg_helper.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/resolve_proxy_msg_helper.h
diff --git a/content/browser/resolve_proxy_msg_helper.h b/content/browser/resolve_proxy_msg_helper.h
index 920ff74199f74457e4de22fea7702d6654a4f43f..a575ed8acf7b4d32ad6798d7ab7b55505f01a5f3 100644
--- a/content/browser/resolve_proxy_msg_helper.h
+++ b/content/browser/resolve_proxy_msg_helper.h
@@ -37,16 +37,17 @@ class CONTENT_EXPORT ResolveProxyMsgHelper
// Constructor used by unittests.
explicit ResolveProxyMsgHelper(net::ProxyService* proxy_service);
- // Destruction cancels the current outstanding request, and clears the
- // pending queue.
- virtual ~ResolveProxyMsgHelper();
-
// content::BrowserMessageFilter implementation
virtual bool OnMessageReceived(const IPC::Message& message,
bool* message_was_ok) OVERRIDE;
void OnResolveProxy(const GURL& url, IPC::Message* reply_msg);
+ protected:
+ // Destruction cancels the current outstanding request, and clears the
+ // pending queue.
+ virtual ~ResolveProxyMsgHelper();
+
private:
// Callback for the ProxyService (bound to |callback_|).
void OnResolveProxyCompleted(int result);
« no previous file with comments | « content/browser/renderer_host/text_input_client_message_filter.mm ('k') | content/browser/resolve_proxy_msg_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698