Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: content/browser/renderer_host/resource_dispatcher_host_unittest.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/resource_dispatcher_host_unittest.cc
diff --git a/content/browser/renderer_host/resource_dispatcher_host_unittest.cc b/content/browser/renderer_host/resource_dispatcher_host_unittest.cc
index 876aa76751e167f73096657b2cc3bfde22f9817d..078b912cafb39b08bc74dfe40bc409e1082d854f 100644
--- a/content/browser/renderer_host/resource_dispatcher_host_unittest.cc
+++ b/content/browser/renderer_host/resource_dispatcher_host_unittest.cc
@@ -178,6 +178,9 @@ class ForwardingFilter : public ResourceMessageFilter {
return dest_->Send(msg);
}
+ protected:
+ virtual ~ForwardingFilter() {}
+
private:
IPC::Message::Sender* dest_;
@@ -706,15 +709,19 @@ class TestFilter : public ForwardingFilter {
}
// ForwardingFilter override
- virtual bool Send(IPC::Message* msg) {
+ virtual bool Send(IPC::Message* msg) OVERRIDE {
// no messages should be received when the process has been canceled
if (has_canceled_)
received_after_canceled_++;
delete msg;
return true;
}
+
bool has_canceled_;
int received_after_canceled_;
+
+ private:
+ virtual ~TestFilter() {}
};
// Tests CancelRequestsForProcess
« no previous file with comments | « content/browser/renderer_host/quota_dispatcher_host.cc ('k') | content/browser/renderer_host/socket_stream_dispatcher_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698