Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1754)

Unified Diff: content/browser/renderer_host/p2p/socket_dispatcher_host.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/p2p/socket_dispatcher_host.h
diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.h b/content/browser/renderer_host/p2p/socket_dispatcher_host.h
index 9f664fec2e7744d1f83580212eaf2860bf95e9ae..508543431bcb4b539cf7fd372b8bbddac9c836d6 100644
--- a/content/browser/renderer_host/p2p/socket_dispatcher_host.h
+++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.h
@@ -9,6 +9,7 @@
#include "content/common/p2p_sockets.h"
#include "content/public/browser/browser_message_filter.h"
+#include "content/public/browser/browser_thread.h"
#include "net/base/ip_endpoint.h"
#include "net/base/network_change_notifier.h"
@@ -22,7 +23,6 @@ class P2PSocketDispatcherHost
public net::NetworkChangeNotifier::IPAddressObserver {
public:
P2PSocketDispatcherHost(content::ResourceContext* resource_context);
- virtual ~P2PSocketDispatcherHost();
// content::BrowserMessageFilter overrides.
virtual void OnChannelClosing() OVERRIDE;
@@ -33,7 +33,13 @@ class P2PSocketDispatcherHost
// net::NetworkChangeNotifier::IPAddressObserver interface.
virtual void OnIPAddressChanged() OVERRIDE;
+ protected:
+ virtual ~P2PSocketDispatcherHost();
+
private:
+ friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;
+ friend class base::DeleteHelper<P2PSocketDispatcherHost>;
+
typedef std::pair<int32, int> ExtendedSocketId;
typedef std::map<ExtendedSocketId, P2PSocketHost*> SocketsMap;

Powered by Google App Engine
This is Rietveld 408576698