content/browser/geolocation/arbitrator_dependency_factories_for_test.cc - Issue 10068037: RefCounted types should not have public destructors, content/browser part 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/arbitrator_dependency_factories_for_test.cc

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: MSVC fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/geolocation/arbitrator_dependency_factories_for_test.h ('k') | content/browser/geolocation/arbitrator_dependency_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/arbitrator_dependency_factories_for_test.cc

diff --git a/content/browser/geolocation/arbitrator_dependency_factories_for_test.cc b/content/browser/geolocation/arbitrator_dependency_factories_for_test.cc

index 8b2f7000226d6d376e4a06124013ed4828c26e6f..0b449302022d12389bcd01ccad3ba6bbddb774d2 100644

--- a/content/browser/geolocation/arbitrator_dependency_factories_for_test.cc

+++ b/content/browser/geolocation/arbitrator_dependency_factories_for_test.cc

@@ -12,9 +12,6 @@ GeolocationArbitratorDependencyFactoryWithLocationProvider::

: factory_function_(factory_function) {

}

-GeolocationArbitratorDependencyFactoryWithLocationProvider::

- ~GeolocationArbitratorDependencyFactoryWithLocationProvider() {}

LocationProviderBase*

GeolocationArbitratorDependencyFactoryWithLocationProvider::

NewNetworkLocationProvider(

@@ -30,3 +27,8 @@ GeolocationArbitratorDependencyFactoryWithLocationProvider::

NewSystemLocationProvider() {

return NULL;

}

+GeolocationArbitratorDependencyFactoryWithLocationProvider::

+~GeolocationArbitratorDependencyFactoryWithLocationProvider() {