Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: content/browser/appcache/chrome_appcache_service.h

Issue 10068037: RefCounted types should not have public destructors, content/browser part 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: MSVC fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/chrome_appcache_service.h
diff --git a/content/browser/appcache/chrome_appcache_service.h b/content/browser/appcache/chrome_appcache_service.h
index 6fb7785cf12557898096ac9d80429b5cce4631ba..82d4d37a02a1d9cae27f6662cce2d01d345dc52b 100644
--- a/content/browser/appcache/chrome_appcache_service.h
+++ b/content/browser/appcache/chrome_appcache_service.h
@@ -35,30 +35,35 @@ struct ChromeAppCacheServiceDeleter;
// TODO(dpranke): Fix dependencies on AppCacheService so that we don't have
// to worry about clients calling AppCacheService methods.
class CONTENT_EXPORT ChromeAppCacheService
- : public base::RefCountedThreadSafe<
- ChromeAppCacheService, ChromeAppCacheServiceDeleter>,
+ : public base::RefCountedThreadSafe<ChromeAppCacheService,
+ ChromeAppCacheServiceDeleter>,
NON_EXPORTED_BASE(public appcache::AppCacheService),
NON_EXPORTED_BASE(public appcache::AppCachePolicy) {
public:
explicit ChromeAppCacheService(quota::QuotaManagerProxy* proxy);
- virtual ~ChromeAppCacheService();
void InitializeOnIOThread(
const FilePath& cache_path, // may be empty to use in-memory structures
content::ResourceContext* resource_context,
scoped_refptr<quota::SpecialStoragePolicy> special_storage_policy);
- private:
- friend struct ChromeAppCacheServiceDeleter;
-
- void DeleteOnCorrectThread() const;
-
// AppCachePolicy overrides
virtual bool CanLoadAppCache(const GURL& manifest_url,
const GURL& first_party) OVERRIDE;
virtual bool CanCreateAppCache(const GURL& manifest_url,
const GURL& first_party) OVERRIDE;
+ protected:
+ virtual ~ChromeAppCacheService();
+
+ private:
+ friend class base::DeleteHelper<ChromeAppCacheService>;
+ friend class base::RefCountedThreadSafe<ChromeAppCacheService,
+ ChromeAppCacheServiceDeleter>;
+ friend struct ChromeAppCacheServiceDeleter;
+
+ void DeleteOnCorrectThread() const;
+
content::ResourceContext* resource_context_;
FilePath cache_path_;
« no previous file with comments | « content/browser/appcache/appcache_dispatcher_host.cc ('k') | content/browser/appcache/chrome_appcache_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698