RefCounted types should not have public destructors, content/browser part 1

content/browser/trace_subscriber_stdio.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/trace_subscriber_stdio.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "content/public/browser/browser_thread.h"
 
 namespace content {
 
 // All method calls on this class are done on a SequencedWorkerPool thread.
 class TraceSubscriberStdioImpl
     : public base::RefCountedThreadSafe<TraceSubscriberStdioImpl> {
  public:
   explicit TraceSubscriberStdioImpl(const FilePath& path)
       : path_(path),
         file_(0) {}
 
-  ~TraceSubscriberStdioImpl() {
-    CloseFile();
-  }
-
   void OnStart() {
     DCHECK(!file_);
     file_ = file_util::OpenFile(path_, "w+");
     if (IsValid()) {
       LOG(INFO) << "Logging performance trace to file: " << path_.value();
       trace_buffer_.SetOutputCallback(
           base::Bind(&TraceSubscriberStdioImpl::Write, this));
       trace_buffer_.Start();
     } else {
       LOG(ERROR) << "Failed to open performance trace file: " << path_.value();
     }
   }
 
   void OnData(const scoped_refptr<base::RefCountedString>& data_ptr) {
     trace_buffer_.AddFragment(data_ptr->data());
   }
 
   void OnEnd() {
     trace_buffer_.Finish();
     CloseFile();
   }
 
  private:
+  friend class base::RefCountedThreadSafe<TraceSubscriberStdioImpl>;
+
+  ~TraceSubscriberStdioImpl() {
+    CloseFile();
+  }
+
   bool IsValid() {
     return file_ && (0 == ferror(file_));
   }
 
   void CloseFile() {
     if (file_) {
       fclose(file_);
       file_ = 0;
     }
   }
@@ skipping 30 matching lines @@
 }
 
 void TraceSubscriberStdio::OnTraceDataCollected(
     const scoped_refptr<base::RefCountedString>& data_ptr) {
   BrowserThread::PostBlockingPoolSequencedTask(
       __FILE__, FROM_HERE,
       base::Bind(&TraceSubscriberStdioImpl::OnData, impl_.get(), data_ptr));
 }
 
 }  // namespace content