RefCounted types should not have public destructors, content/browser part 1

content/browser/renderer_host/media/video_capture_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // VideoCaptureController is the glue between VideoCaptureHost,
 // VideoCaptureManager and VideoCaptureDevice.
 // It provides functions for VideoCaptureHost to start a VideoCaptureDevice and
 // is responsible for keeping track of shared DIBs and filling them with I420
 // video frames for IPC communication between VideoCaptureHost and
 // VideoCaptureMessageFilter.
@@ skipping 21 matching lines @@
 namespace media_stream {
 class VideoCaptureManager;
 }  // namespace media_stream
 
 class VideoCaptureController
     : public base::RefCountedThreadSafe<VideoCaptureController>,
       public media::VideoCaptureDevice::EventHandler {
  public:
   VideoCaptureController(
       media_stream::VideoCaptureManager* video_capture_manager);
-  virtual ~VideoCaptureController();
 
   // Start video capturing and try to use the resolution specified in
   // |params|.
   // When capturing has started, the |event_handler| receives a call OnFrameInfo
   // with resolution that best matches the requested that the video
   // capture device support.
   void StartCapture(const VideoCaptureControllerID& id,
                     VideoCaptureControllerEventHandler* event_handler,
                     base::ProcessHandle render_process,
                     const media::VideoCaptureParams& params);
@@ skipping 14 matching lines @@
                     int buffer_id);
 
   // Implement media::VideoCaptureDevice::EventHandler.
   virtual void OnIncomingCapturedFrame(const uint8* data,
                                        int length,
                                        base::Time timestamp) OVERRIDE;
   virtual void OnError() OVERRIDE;
   virtual void OnFrameInfo(
       const media::VideoCaptureDevice::Capability& info) OVERRIDE;
 
+ protected:
+  virtual ~VideoCaptureController();
+
  private:
+  friend class base::RefCountedThreadSafe<VideoCaptureController>;
+
   struct ControllerClient;
   typedef std::list<ControllerClient*> ControllerClients;
 
   // Callback when manager has stopped device.
   void OnDeviceStopped();
 
   // Worker functions on IO thread.
   void DoIncomingCapturedFrameOnIOThread(int buffer_id, base::Time timestamp);
   void DoFrameInfoOnIOThread(const media::VideoCaptureDevice::Capability info);
   void DoErrorOnIOThread();
-  void DoDeviceStateOnIOThread(bool in_use);
   void DoDeviceStoppedOnIOThread();
 
   // Send frame info and init buffers to |client|.
   void SendFrameInfoAndBuffers(ControllerClient* client, int buffer_size);
 
   // Helpers.
   // Find a client of |id| and |handler| in |clients|.
   ControllerClient* FindClient(
       const VideoCaptureControllerID& id,
       VideoCaptureControllerEventHandler* handler,
@@ skipping 31 matching lines @@
 
   media_stream::VideoCaptureManager* video_capture_manager_;
 
   bool device_in_use_;
   video_capture::State state_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(VideoCaptureController);
 };
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_CONTROLLER_H_