RefCounted types should not have public destructors, content/browser part 1

content/browser/plugin_data_remover_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/plugin_data_remover_impl.h"
 
 #include "base/bind.h"
 #include "base/metrics/histogram.h"
+#include "base/sequenced_task_runner_helpers.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/utf_string_conversions.h"
 #include "base/version.h"
 #include "content/browser/plugin_process_host.h"
 #include "content/browser/plugin_service_impl.h"
 #include "content/browser/renderer_host/pepper_file_message_filter.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/common/plugin_messages.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/browser_thread.h"
@@ skipping 47 matching lines @@
   Context(base::Time begin_time, BrowserContext* browser_context)
       : event_(new base::WaitableEvent(true, false)),
         begin_time_(begin_time),
         is_removing_(false),
         browser_context_path_(browser_context->GetPath()),
         resource_context_(browser_context->GetResourceContext()),
         channel_(NULL) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   }
 
-  virtual ~Context() {
-  }
-
   void Init(const std::string& mime_type) {
     BrowserThread::PostTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(&Context::InitOnIOThread, this, mime_type));
     BrowserThread::PostDelayedTask(
         BrowserThread::IO,
         FROM_HERE,
         base::Bind(&Context::OnTimeout, this),
         base::TimeDelta::FromMilliseconds(kRemovalTimeoutMs));
@@ skipping 43 matching lines @@
   }
 
   virtual bool OffTheRecord() OVERRIDE {
     return false;
   }
 
   virtual ResourceContext* GetResourceContext() OVERRIDE {
     return resource_context_;
   }
 
-  virtual void SetPluginInfo(const webkit::WebPluginInfo& info) OVERRIDE {
-  }
+  virtual void SetPluginInfo(const webkit::WebPluginInfo& info) OVERRIDE {}
 
-  virtual void OnFoundPluginProcessHost(PluginProcessHost* host) OVERRIDE {
-  }
+  virtual void OnFoundPluginProcessHost(PluginProcessHost* host) OVERRIDE {}
 
-  virtual void OnSentPluginChannelRequest() OVERRIDE {
-  }
+  virtual void OnSentPluginChannelRequest() OVERRIDE {}
 
   virtual void OnChannelOpened(const IPC::ChannelHandle& handle) OVERRIDE {
     ConnectToChannel(handle, false);
     // Balancing the AddRef call.
     Release();
   }
 
   virtual void OnError() OVERRIDE {
     LOG(ERROR) << "Couldn't open plugin channel";
     SignalDone();
@@ skipping 34 matching lines @@
   virtual void OnChannelError() OVERRIDE {
     if (is_removing_) {
       NOTREACHED() << "Channel error";
       SignalDone();
     }
   }
 
   base::WaitableEvent* event() { return event_.get(); }
 
  private:
+  friend struct BrowserThread::DeleteOnThread<BrowserThread::IO>;
+  friend class base::DeleteHelper<Context>;
+  virtual ~Context() {}
+
   // Connects the client side of a newly opened plug-in channel.
   void ConnectToChannel(const IPC::ChannelHandle& handle, bool is_ppapi) {
     DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
     // If we timed out, don't bother connecting.
     if (!is_removing_)
       return;
 
     DCHECK(!channel_.get());
     channel_.reset(new IPC::Channel(handle, IPC::Channel::MODE_CLIENT, this));
@@ skipping 84 matching lines @@
 
 base::WaitableEvent* PluginDataRemoverImpl::StartRemoving(
     base::Time begin_time) {
   DCHECK(!context_.get());
   context_ = new Context(begin_time, browser_context_);
   context_->Init(mime_type_);
   return context_->event();
 }
 
 }  // namespace content