RefCounted types should not have public destructors, content/browser part 1

content/browser/geolocation/location_arbitrator_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/geolocation/arbitrator_dependency_factory.h"
 #include "content/browser/geolocation/fake_access_token_store.h"
 #include "content/browser/geolocation/geolocation_observer.h"
 #include "content/browser/geolocation/location_arbitrator.h"
 #include "content/browser/geolocation/location_provider.h"
@@ skipping 52 matching lines @@
   SetPositionFix(provider, 51.0, -0.1, 400);
 }
 
 class MockDependencyFactory : public GeolocationArbitratorDependencyFactory {
  public:
   explicit MockDependencyFactory(AccessTokenStore* access_token_store)
       : cell_(NULL),
         gps_(NULL),
         access_token_store_(access_token_store) {
   }
+
   virtual GeolocationArbitrator::GetTimeNow GetTimeFunction() {
     return GetTimeNowForTest;
   }
+
   virtual AccessTokenStore* NewAccessTokenStore() {
     return access_token_store_.get();
   }
+
   virtual LocationProviderBase* NewNetworkLocationProvider(
       AccessTokenStore* access_token_store,
       net::URLRequestContextGetter* context,
       const GURL& url,
       const string16& access_token) {
     return new MockLocationProvider(&cell_);
   }
+
   virtual LocationProviderBase* NewSystemLocationProvider() {
     return new MockLocationProvider(&gps_);
   }
 
   // Two location providers, with nice short names to make the tests more
   // readable. Note |gps_| will only be set when there is a high accuracy
   // observer registered (and |cell_| when there's at least one observer of any
   // type).
   MockLocationProvider* cell_;
   MockLocationProvider* gps_;
 
   scoped_refptr<AccessTokenStore> access_token_store_;
+
+ private:
+  virtual ~MockDependencyFactory() {}
 };
 
 class GeolocationLocationArbitratorTest : public testing::Test {
  protected:
   // testing::Test
   virtual void SetUp() {
     access_token_store_ = new NiceMock<FakeAccessTokenStore>;
     observer_.reset(new MockLocationObserver);
     dependency_factory_ = new MockDependencyFactory(access_token_store_);
     GeolocationArbitrator::SetDependencyFactoryForTest(
@@ skipping 172 matching lines @@
   CheckLastPositionInfo(3.5657104, 139.690341, 300);
 
   // 2 minutes later
   AdvanceTimeNow(base::TimeDelta::FromMinutes(2));
   // Arrive in station. Cell moves but GPS is stale. Switch to fresher cell.
   SetPositionFix(cell(), 3.5658700, 139.069979, 1000);
   CheckLastPositionInfo(3.5658700, 139.069979, 1000);
 }
 
 }  // namespace