Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_message_filter_mac.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
index d858e69605069e89e5b6ef8dcee7f2f9bce0ee24..3b962d128ab72f9cd605483b01e143c3b785e915 100644
--- a/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
+++ b/chrome/browser/spellchecker/spellcheck_message_filter_mac_browsertest.cc
@@ -13,10 +13,6 @@
#include "chrome/test/base/ui_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
-namespace {
-
-typedef InProcessBrowserTest SpellCheckMessageFilterMacBrowserTest;
-
// Fake filter for testing, which stores sent messages and
// allows verification by the test case.
class TestingSpellCheckMessageFilter : public SpellCheckMessageFilterMac {
@@ -25,10 +21,6 @@ class TestingSpellCheckMessageFilter : public SpellCheckMessageFilterMac {
: SpellCheckMessageFilterMac(),
loop_(loop) { }
- ~TestingSpellCheckMessageFilter() {
- STLDeleteContainerPointers(sent_messages_.begin(), sent_messages_.end());
- }
-
virtual bool Send(IPC::Message* message) {
sent_messages_.push_back(message);
loop_->PostTask(FROM_HERE, MessageLoop::QuitClosure());
@@ -37,8 +29,15 @@ class TestingSpellCheckMessageFilter : public SpellCheckMessageFilterMac {
std::vector<IPC::Message*> sent_messages_;
MessageLoopForUI* loop_;
+
+ private:
+ ~TestingSpellCheckMessageFilter() {
+ STLDeleteContainerPointers(sent_messages_.begin(), sent_messages_.end());
+ }
};
+typedef InProcessBrowserTest SpellCheckMessageFilterMacBrowserTest;
+
// Uses browsertest to setup chrome threads.
IN_PROC_BROWSER_TEST_F(SpellCheckMessageFilterMacBrowserTest,
SpellCheckReturnMessage) {
@@ -66,5 +65,3 @@ IN_PROC_BROWSER_TEST_F(SpellCheckMessageFilterMacBrowserTest,
EXPECT_EQ(sent_results[0].type,
SpellCheckResult::SPELLING);
}
-
-} // namespace
« no previous file with comments | « chrome/browser/spellchecker/spellcheck_message_filter_mac.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698