Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: chrome/browser/speech/speech_input_extension_api.h

Issue 10068036: RefCounted types should not have public destructors, chrome/browser/ part 5 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win fix Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/speech/speech_input_extension_api.h
diff --git a/chrome/browser/speech/speech_input_extension_api.h b/chrome/browser/speech/speech_input_extension_api.h
index c3f613580ee229b189493e4be8fb383a21a69f39..fd7fba3806646ea3396c09aeda366e71cfc71795 100644
--- a/chrome/browser/speech/speech_input_extension_api.h
+++ b/chrome/browser/speech/speech_input_extension_api.h
@@ -13,20 +13,22 @@
// recognition in the framework of the extension API state machine.
class SpeechInputAsyncFunction : public AsyncExtensionFunction,
public content::NotificationObserver {
+ public:
+ // content::NotificationObserver.
+ virtual void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) OVERRIDE;
+
protected:
SpeechInputAsyncFunction(int start_state, int transition_state,
int end_state, int transition_notification);
virtual ~SpeechInputAsyncFunction();
+ // ExtensionFunction:
virtual void Run() OVERRIDE;
virtual bool RunImpl() = 0;
private:
- // content::NotificationObserver.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
// To be defined on construction by derived classes.
int start_state_;
int transition_state_;
@@ -41,35 +43,48 @@ class SpeechInputAsyncFunction : public AsyncExtensionFunction,
// Implements experimental.speechInput.start.
class StartSpeechInputFunction : public SpeechInputAsyncFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.start");
+
StartSpeechInputFunction();
- virtual ~StartSpeechInputFunction() {}
protected:
+ // SpeechInputAsyncFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.start");
+
+ private:
+ virtual ~StartSpeechInputFunction() {}
};
// Implements experimental.speechInput.stop.
class StopSpeechInputFunction : public SpeechInputAsyncFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.stop");
+
StopSpeechInputFunction();
- virtual ~StopSpeechInputFunction() {}
protected:
+ // SpeechInputAsyncFunction:
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.stop");
+
+ private:
+ virtual ~StopSpeechInputFunction() {}
};
// Implements experimental.speechInput.isRecording.
class IsRecordingSpeechInputFunction : public SyncExtensionFunction {
public:
+ DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.isRecording");
+
// Called back from SpeechInputExtensionManager in the UI thread.
void SetResult(bool result);
protected:
+ // ExtensionFunction:
virtual void Run() OVERRIDE;
virtual bool RunImpl() OVERRIDE;
- DECLARE_EXTENSION_FUNCTION_NAME("experimental.speechInput.isRecording");
+
+ private:
+ virtual ~IsRecordingSpeechInputFunction() {}
};
#endif // CHROME_BROWSER_SPEECH_SPEECH_INPUT_EXTENSION_API_H_
« no previous file with comments | « chrome/browser/safe_browsing/safe_browsing_test.cc ('k') | chrome/browser/speech/speech_input_extension_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698