RefCounted types should not have public destructors, chrome/browser/ part 5

chrome/browser/safe_browsing/malware_details_cache.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Implementation of the MalwareDetails class.
 
 #include "chrome/browser/safe_browsing/malware_details.h"
 
 #include "base/bind.h"
 #include "base/lazy_instance.h"
@@ skipping 19 matching lines @@
 // of the whole report and the user's bandwidth.
 static const uint32 kMaxBodySizeBytes = 1024;
 
 MalwareDetailsCacheCollector::MalwareDetailsCacheCollector()
     : resources_(NULL),
       result_(NULL),
       has_started_(false),
       current_fetch_(NULL) {
 }
 
-MalwareDetailsCacheCollector::~MalwareDetailsCacheCollector() {
-}
-
 void MalwareDetailsCacheCollector::StartCacheCollection(
     net::URLRequestContextGetter* request_context_getter,
     safe_browsing::ResourceMap* resources,
     bool* result,
     const base::Closure& callback) {
   // Start the data collection from the HTTP cache. We use a URLFetcher
   // and set the right flags so we only hit the cache.
   DVLOG(1) << "Getting cache data for all urls...";
   request_context_getter_ = request_context_getter;
   resources_ = resources;
   resources_it_ = resources_->begin();
   result_ = result;
   callback_ = callback;
   has_started_ = true;
 
   // Post a task in the message loop, so the callers don't need to
   // check if we call their callback immediately.
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&MalwareDetailsCacheCollector::OpenEntry, this));
 }
 
 bool MalwareDetailsCacheCollector::HasStarted() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   return has_started_;
 }
 
+MalwareDetailsCacheCollector::~MalwareDetailsCacheCollector() {}
+
 // Fetch a URL and advance to the next one when done.
 void MalwareDetailsCacheCollector::OpenEntry() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DVLOG(1) << "OpenEntry";
 
   if (resources_it_ == resources_->end()) { // We are done.
     AllDone(true);
     return;
   }
 
@@ skipping 122 matching lines @@
       base::Bind(&MalwareDetailsCacheCollector::OpenEntry, this));
 }
 
 void MalwareDetailsCacheCollector::AllDone(bool success) {
   DVLOG(1) << "AllDone";
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   *result_ = success;
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, callback_);
   callback_.Reset();
 }